proposed new repo: tools

[Dan Kortschak]

A while back I suggested that we generalise some of our static code
checks for banned/deprecated packages. Seb put together some code for
this and incorporated it in a test[1], but it seems to me that this
kind of thing has general utility, so it might be worth providing it as
a linter to the broader community. There may well be other tools that
we'll need so he and I though it might be worth making a tools repo.

Does this sound reasonable to others?

Dan

[1]https://github.com/gonum/gonum/pull/469

[Vladimír Chalupecký]

To me it sounds reasonable.

[Brendan Tracey]

This sounds reasonable to me as well.

Two checks that would be nice:

1) Checking that every file has a copyright header at the top

2) Checking that there aren't any outside imports for gonum.org/v1/gonum aside from the standard library and golang.org/x imports. It would be nice to have a check that we don't add extra outside dependencies. 

[Sebastien Binet]

On Thu, May 24, 2018 at 7:20 PM Brendan Tracey <tracey....@gmail.com> wrote:

This sounds reasonable to me as well.

Two checks that would be nice:

1) Checking that every file has a copyright header at the top

SGTM

 

2) Checking that there aren't any outside imports for gonum.org/v1/gonum aside from the standard library and golang.org/x imports. It would be nice to have a check that we don't add extra outside dependencies. 

Good idea!

-s

[Sebastien Binet]

it seems everybody is in violent agreement.

could somebody create that repo? (I don't have enough karma to do that myself.)

-s

[Dan Kortschak]

Done.

On Fri, 2018-06-01 at 09:52 +0200, Sebastien Binet wrote:
> On Mon, May 21, 2018 at 4:58 AM Dan Kortschak <dan.kortschak@adelaide