godoc shows methods where they're not defined

[Tamás Gulácsi]

Hi,

Both my local go1.9-beta1, and godoc.org shows BeginTx on *DirectedLob, but that's defined on *conn, a private type!

What I'm doing wrong here?

http://godoc.org/gopkg.in/goracle.v2

Thanks,

Tamás Gulácsi

[Nathan Kerr]

Since *conn is embedded in DirectLob, its method sets are promoted to DirectLob's method sets. Since BeginTx is now part of DirectLob's method sets, it acts like any other member of the method sets would; in this case it is an exported method on DirectLob.

This is a feature because it allows the use of *conn's methods while not allowing direct, external access to *conn. If you want to make only part of *conn's method sets available, don't embed *conn (i.e., give it a name) and write wrappers for the methods you need.

See https://golang.org/ref/spec#Struct_types for embedded field promotion rules.

[Tamás Gulácsi]

Thanks!
In retrospect, it's obvious :)