linter issues

em...@alexd.ch

unread,

Oct 24, 2016, 10:59:05 AM10/24/16

to golang-dev

I noticed there are quite a number of linter issues in the go codebase.

Is it worth it to fix them?

If yes, I would assume it is proably a good idea to create an issue per package and fix it?

Brad Fitzpatrick

unread,

Oct 24, 2016, 11:05:12 AM10/24/16

to em...@alexd.ch, golang-dev

No need for all the issues. You can send fixes if you want (even spanning packages), as long as you review each and verify they're real. lint can have false positives.

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Joe Tsai

unread,

Oct 25, 2016, 4:20:39 AM10/25/16

to golang-dev, em...@alexd.ch

Keep in mind that some linter errors may be legitimate, but we may not be able to address them. Some parts of the standard library predates the formulation of the "best practices" that lint tries to enforce.

JT

On Monday, October 24, 2016 at 8:05:12 AM UTC-7, Brad Fitzpatrick wrote:

No need for all the issues. You can send fixes if you want (even spanning packages), as long as you review each and verify they're real. lint can have false positives.

On Sun, Oct 23, 2016 at 6:32 AM, <em...@alexd.ch> wrote:

I noticed there are quite a number of linter issues in the go codebase.
Is it worth it to fix them?
If yes, I would assume it is proably a good idea to create an issue per package and fix it?

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.

Reply all

Reply to author

Forward