Release freeze for 1.10 release starts tomorrow

[Ian Lance Taylor]

Per the release schedule
(https://github.com/golang/go/wiki/Go-Release-Cycle) the release
freeze for Go 1.10 starts tomorrow, Wednesday, November 1. Starting
tomorrow, no new features will be accepted for 1.10.

If there is something you are really anxious to get in, let us know,
and we can consider making an exception if the work will be done very
soon.

Changes sent before the feature freeze starts may still be reviewed
and committed during the freeze, as long as they are committed in the
next week or two.

During the feature freeze, bug fixes and doc improvements are still
accepted and, indeed, encouraged.

The feature freeze only applies to the main repository and the
portions of golang.org/x/tools included in a release, not to the
golang.org/x repositories in general. Of course, work there should
keep the overall release cycle in mind.

Thanks to all the many contributors to Go. By my count, during this
cycle there have been 1355 changes to the main repository, of which
706 were made by people neither on the core Go team nor at Google.
And there is also all the significant work going into reporting,
triaging, and analyzing issues, arranging meetups and
conferences,writing articles, and helping people in the various
forums. Go could not be successful without this amazing level of
community support.

Ian

[David Crawshaw]

I took a vacation not realizing the freeze was so close, so I may be
two-or-three days late with my fuchsia changes. (I've got it started
in CL 72611, but the reorg into x/sys slowed me down.)

> --
> You received this message because you are subscribed to the Google Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[iskander...@intel.com]

I working on AVX1+AVX2 instructions implementation in Go asm.
x86avxgen was created to emit code that is missing in x86 asm backend.

Most CL are approved, generator is pushed to arch repo.

https://go-review.googlesource.com/c/go/+/70630

https://go-review.googlesource.com/c/arch/+/66972

https://go-review.googlesource.com/c/arch/+/66971

I am waiting https://go-review.googlesource.com/c/go/+/70650 to be approved (already ping'ed recently, hope reviewer will come back soon).

After it is merged, next CL will apply x86avxgen output.

This, in theory, affects only x86 asm backend;

but CL70650 may also affect other asm backends (it touches obj/link.go).

[Lynn A. Boger]

On 10/31/2017 09:38 AM, Ian Lance Taylor wrote:
> Per the release schedule
> (https://github.com/golang/go/wiki/Go-Release-Cycle) the release
> freeze for Go 1.10 starts tomorrow, Wednesday, November 1. Starting
> tomorrow, no new features will be accepted for 1.10.
>
> If there is something you are really anxious to get in, let us know,
> and we can consider making an exception if the work will be done very
> soon.

How soon is "very soon"? Our security team has been working on
asm implementations for a few crypto functions that we'd really
like to get in. They are still testing it and say it is at least a week
yet.

[Ian Lance Taylor]

On Tue, Oct 31, 2017 at 10:15 AM, David Crawshaw <craw...@golang.org> wrote:
> I took a vacation not realizing the freeze was so close, so I may be
> two-or-three days late with my fuchsia changes. (I've got it started
> in CL 72611, but the reorg into x/sys slowed me down.)

OK.

Ian

[Ian Lance Taylor]

On Tue, Oct 31, 2017 at 9:16 AM, <iskander...@intel.com> wrote:
> I working on AVX1+AVX2 instructions implementation in Go asm.
> x86avxgen was created to emit code that is missing in x86 asm backend.
> Most CL are approved, generator is pushed to arch repo.
>
> https://go-review.googlesource.com/c/go/+/70630
> https://go-review.googlesource.com/c/arch/+/66972
> https://go-review.googlesource.com/c/arch/+/66971
>
> I am waiting https://go-review.googlesource.com/c/go/+/70650 to be approved
> (already ping'ed recently, hope reviewer will come back soon).
> After it is merged, next CL will apply x86avxgen output.
>
> This, in theory, affects only x86 asm backend;
> but CL70650 may also affect other asm backends (it touches obj/link.go).

In any case sounds like the CLs are out for review, so there is no
problem getting them into 1.10 if they can be reviewed promptly.

Ian

[Ian Lance Taylor]

On Tue, Oct 31, 2017 at 1:48 PM, Lynn A. Boger
<lab...@linux.vnet.ibm.com> wrote:
>
> On 10/31/2017 09:38 AM, Ian Lance Taylor wrote:
>>
>> Per the release schedule
>> (https://github.com/golang/go/wiki/Go-Release-Cycle) the release
>> freeze for Go 1.10 starts tomorrow, Wednesday, November 1. Starting
>> tomorrow, no new features will be accepted for 1.10.
>>
>> If there is something you are really anxious to get in, let us know,
>> and we can consider making an exception if the work will be done very
>> soon.
>
>
> How soon is "very soon"? Our security team has been working on
> asm implementations for a few crypto functions that we'd really
> like to get in. They are still testing it and say it is at least a week
> yet.

OK, but it can't really go beyond that.

Ian

[David Crawshaw]

On Tue, Oct 31, 2017 at 5:00 PM, Ian Lance Taylor <ia...@golang.org> wrote:
> On Tue, Oct 31, 2017 at 10:15 AM, David Crawshaw <craw...@golang.org> wrote:
>> I took a vacation not realizing the freeze was so close, so I may be
>> two-or-three days late with my fuchsia changes. (I've got it started
>> in CL 72611, but the reorg into x/sys slowed me down.)
>
> OK.

While working on this today I ran into several issues, most around the
builder, but a couple in the poller implementation. Rather than
scramble for bugfixes through the 1.10 freeze, I'm going to push this
to the open of 1.11.

[roger peppe]

I suspect it's too late, but I'd forgotten about
https://go-review.googlesource.com/c/go/+/68091 which has
been sitting around for a while. Any chance it might be able to land for 1.10 ?

[Brad Fitzpatrick]

Seems fine if you, me, and Tom can figure out the RequestMethod wart. I replied there.

> To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.

> For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.

[roger peppe]

I updated the CL earlier today with something that might be a
reasonable solution.
PTAL.

>> > an email to golang-dev+...@googlegroups.com.

>> > For more options, visit https://groups.google.com/d/optout.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an

>> email to golang-dev+...@googlegroups.com.

[ilya....@intel.com]

Does R=go1.11 works?

[Brad Fitzpatrick]

Are you asking whether our dashboards respect it? They used to. Andy, do they still?

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.

[Andrew Bonventre (Bons)]

I’m missing some context. Do you mean R=go1.11 in the body of the commit message? If so, then no.

On Tue, Nov 7, 2017 at 8:13 PM Brad Fitzpatrick <brad...@golang.org> wrote:

Are you asking whether our dashboards respect it? They used to. Andy, do they still?

On Tue, Nov 7, 2017 at 12:12 PM, <ilya....@intel.com> wrote:

Does R=go1.11 works?

On Tuesday, October 31, 2017 at 9:39:05 AM UTC-5, Ian Lance Taylor wrote:

Per the release schedule
(https://github.com/golang/go/wiki/Go-Release-Cycle) the release
freeze for Go 1.10 starts tomorrow, Wednesday, November 1.  Starting
tomorrow, no new features will be accepted for 1.10.

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.

[ilya....@intel.com]

Previously you could mark CL as targeting next release by replying with R=go... (e. g. https://go-review.googlesource.com/c/go/+/47359 was sent during 1.9 freeze, but is marked R=go1.10 )

[Andrew Bonventre (Bons)]

How was this displayed on the dashboard if there was no associated issue (like the change you mention)?

Supporting this is easy, but I just need to know how it looks :)

[Ian Lance Taylor]

On Tue, Nov 7, 2017 at 1:50 PM, 'Andrew Bonventre (Bons)' via
golang-dev <golan...@googlegroups.com> wrote:
>
> How was this displayed on the dashboard if there was no associated issue
> (like the change you mention)?
>
> Supporting this is easy, but I just need to know how it looks :)

Has the dashboard code changed?

This affected https://dev.golang.org/release . Adding R=go1.11 would
move the CL from the (current) Go1.10 section to a (currently
nonexistent) Go1.11 section farther down.

Ian

[Andrew Bonventre (Bons)]

It was rewritten to use maintner earlier this year.

[Andrew Bonventre (Bons)]

Created https://golang.org/issues/22620 to track the regression.

[Andrew Bonventre (Bons)]

I’m going to look into the code history tomorrow morning, but Russ or Brad, do you know off the top of your head where this info was presented?

The top sections are constructed using GitHub issues with associated CLs, so a single CL isn’t shown in those sections unless it references a GitHub issue.

Were CLs that didn’t have issues shown in that section?

[Russ Cox]

The R=xxx line assigns the reviewer. R=gri means gri is the reviewer. Now Gerrit has a separate Gerrit reviewer list so maybe that's not as useful anymore, so it's OK to ignore those. But dev.golang.org should still handle the special notes:

R=close (don't show this issue until a new patch set is uploaded)
R=go1.11 (don't show this issue until Go 1.11 opens)

They weren't shown somewhere else. They were just not shown at all. It's fine if you want to have a list of "next release" on the bottom of the page or a separate page, but it's also fine (and maybe even better) to just hide them.

Russ

>> email to golang-dev+unsubscribe@googlegroups.com.

>> For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to golang-dev+unsubscribe@googlegroups.com.

> For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.

[Andrew Bonventre (Bons)]

Got it. Thanks, Russ.

To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.