code review 5223043: gotest: document -test.parallel (issue 5223043)

44 views
Skip to first unread message

r...@golang.org

unread,
Oct 6, 2011, 12:58:27 PM10/6/11
to golan...@googlegroups.com, re...@codereview.appspotmail.com
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golan...@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
gotest: document -test.parallel

Please review this at http://codereview.appspot.com/5223043/

Affected files:
M src/cmd/gotest/doc.go


Index: src/cmd/gotest/doc.go
===================================================================
--- a/src/cmd/gotest/doc.go
+++ b/src/cmd/gotest/doc.go
@@ -54,6 +54,7 @@
6.out [-test.v] [-test.run pattern] [-test.bench pattern] \
[-test.cpuprofile=cpu.out] \
[-test.memprofile=mem.out] [-test.memprofilerate=1] \
+ [-test.parallel=0] \
[-test.timeout=10] [-test.short] \
[-test.benchtime=3] [-test.cpu=1,2,3,4]

@@ -86,6 +87,10 @@
Use -test.run or -test.bench to limit profiling to a particular test
or benchmark.

+The -test.parallel flag allows parallel execution of Test functions
+that call test.Parallel. The value of the flag is the maximum number
+of tests to run simultaneous.
+
The -test.short flag tells long-running tests to shorten their run
time. It is off by default but set by all.bash so installations of
the Go tree can do a sanity check but not spend time running


Brad Fitzpatrick

unread,
Oct 6, 2011, 1:11:56 PM10/6/11
to reply, Rob 'Commander' Pike, golan...@googlegroups.com

adverb? Simultaneously?

dsym...@golang.org

unread,
Oct 6, 2011, 1:32:02 PM10/6/11
to r...@golang.org, golan...@googlegroups.com, brad...@golang.org, re...@codereview.appspotmail.com

http://codereview.appspot.com/5223043/diff/1/src/cmd/gotest/doc.go
File src/cmd/gotest/doc.go (right):

http://codereview.appspot.com/5223043/diff/1/src/cmd/gotest/doc.go#newcode92
src/cmd/gotest/doc.go:92: of tests to run simultaneous.
I didn't follow the CL closely, so that probably makes me a good test
case. What does the default value of zero mean?

http://codereview.appspot.com/5223043/

r...@golang.org

unread,
Oct 6, 2011, 1:36:18 PM10/6/11
to golan...@googlegroups.com, brad...@golang.org, dsym...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com

g...@golang.org

unread,
Oct 6, 2011, 1:38:13 PM10/6/11
to r...@golang.org, golan...@googlegroups.com, brad...@golang.org, dsym...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com

Brad Fitzpatrick

unread,
Oct 6, 2011, 1:38:29 PM10/6/11
to r...@golang.org, golan...@googlegroups.com, brad...@golang.org, dsym...@golang.org, re...@codereview.appspotmail.com
LGTM

dsym...@golang.org

unread,
Oct 6, 2011, 1:39:22 PM10/6/11
to r...@golang.org, golan...@googlegroups.com, brad...@golang.org, g...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com

r...@golang.org

unread,
Oct 6, 2011, 1:41:57 PM10/6/11
to r...@golang.org, golan...@googlegroups.com, brad...@golang.org, dsym...@golang.org, g...@golang.org, re...@codereview.appspotmail.com
*** Submitted as
http://code.google.com/p/go/source/detail?r=84bf0597069e ***

gotest: document -test.parallel

R=golang-dev, bradfitz, dsymonds, gri
CC=golang-dev
http://codereview.appspot.com/5223043


http://codereview.appspot.com/5223043/

Reply all
Reply to author
Forward
0 new messages