code review 2660042: gobs: error cleanup part 1. (issue2660042)

[r...@golang.org]

Reviewers: rsc,

Message:
Hello rsc (cc: golan...@googlegroups.com),

I'd like you to review this change.

Description:
gobs: error cleanup part 1.
Remove err from the encoderState and decoderState types, so we're
not always copying to and from various copies of the error, and then
use panic/recover to eliminate lots of error checking.

another pass might take a crack at the same thing for the compilation
phase.

Please review this at http://codereview.appspot.com/2660042/

Affected files:
M src/pkg/gob/Makefile
M src/pkg/gob/codec_test.go
M src/pkg/gob/decode.go
M src/pkg/gob/decoder.go
M src/pkg/gob/encode.go
M src/pkg/gob/encoder.go
M src/pkg/gob/encoder_test.go

[r...@google.com]

LGTM

http://codereview.appspot.com/2660042/

[r...@golang.org]

Hello rsc (cc: golan...@googlegroups.com),

Please take another look.

http://codereview.appspot.com/2660042/

[r...@google.com]

LGTM

http://codereview.appspot.com/2660042/

[r...@golang.org]

*** Submitted as
http://code.google.com/p/go/source/detail?r=7059c89a2346 ***

gobs: error cleanup part 1.
Remove err from the encoderState and decoderState types, so we're
not always copying to and from various copies of the error, and then
use panic/recover to eliminate lots of error checking.

another pass might take a crack at the same thing for the compilation
phase.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2660042

http://codereview.appspot.com/2660042/