go1.9 and pprof vendoring from upstream

[Alberto Donizetti]

Hi golang-dev,

as @rsc wrote a couple months ago about pprof

> Now that we are in sync, the plan is to import upstream pprof around
> the time of the release freeze in each cycle.

What's the plan for the go1.9 vendoring?

I ask because a panic I reported was fixed upstream in march (see
github.com/google/pprof/issues/103) but as far as I know pprof was not
vendored when the go1.9 freeze started, and the reproducer I posted in
that issue still crashes the pprof version currently included in tip.

Thanks,
Alberto

[Josh Bleecher Snyder]

>> Now that we are in sync, the plan is to import upstream pprof around
>> the time of the release freeze in each cycle.
>
> What's the plan for the go1.9 vendoring?

Also golang.org/x/*, the race runtime, maybe others.

-josh

[Russ Cox]

We should vendor those soon, before the beta is cut. Any takers?

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Alberto Donizetti]

How is pprof usually vendored? I see a vendor.json file, which
makes me think 'govendor', but AFAIK it requires the package to
be in GOPATH and indeed it complained on any govendor command
I tried in the folder.

Il giorno mercoledì 14 giugno 2017 18:35:01 UTC+2, rsc ha scritto:

We should vendor those soon, before the beta is cut. Any takers?

On Wed, Jun 7, 2017 at 10:18 AM, Josh Bleecher Snyder <josh...@gmail.com> wrote:

>> Now that we are in sync, the plan is to import upstream pprof around
>> the time of the release freeze in each cycle.
>
> What's the plan for the go1.9 vendoring?

Also golang.org/x/*, the race runtime, maybe others.

-josh

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+...@googlegroups.com.

[Russ Cox]

[reply all this time sorry]

On Tue, Jun 20, 2017 at 3:18 AM, Alberto Donizetti <alb.do...@gmail.com> wrote:

How is pprof usually vendored? I see a vendor.json file, which
makes me think 'govendor', but AFAIK it requires the package to
be in GOPATH and indeed it complained on any govendor command
I tried in the folder.

The procedure is copy the files and update vendor.json by hand.

Russ