[sys] unix: change MemfdCreate flags parameter to int for all GOARCHes

6 views
Skip to first unread message

Tobias Klauser (Gerrit)

unread,
Sep 19, 2018, 10:34:14 AM9/19/18
to Ian Lance Taylor, Brad Fitzpatrick, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Tobias Klauser would like Ian Lance Taylor and Brad Fitzpatrick to review this change.

View Change

unix: change MemfdCreate flags parameter to int for all GOARCHes

For some reason I didn't completely re-generate the zsyscall_linux_*
files for all GOARCHes during review of CL 135915. Do so now such that
the flags parameter is of type int on all GOARCHes.

Change-Id: Ifc4afacfbedb70f3818b23ed3ea468745bbdb455
---
M unix/zsyscall_linux_ppc64.go
M unix/zsyscall_linux_ppc64le.go
M unix/zsyscall_linux_riscv64.go
M unix/zsyscall_linux_s390x.go
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/unix/zsyscall_linux_ppc64.go b/unix/zsyscall_linux_ppc64.go
index 971b72b..1cb8eb4 100644
--- a/unix/zsyscall_linux_ppc64.go
+++ b/unix/zsyscall_linux_ppc64.go
@@ -979,7 +979,7 @@

// THIS FILE IS GENERATED BY THE COMMAND AT THE TOP; DO NOT EDIT

-func MemfdCreate(name string, flags uint) (fd int, err error) {
+func MemfdCreate(name string, flags int) (fd int, err error) {
var _p0 *byte
_p0, err = BytePtrFromString(name)
if err != nil {
diff --git a/unix/zsyscall_linux_ppc64le.go b/unix/zsyscall_linux_ppc64le.go
index 52f3faa..5f0cb9d 100644
--- a/unix/zsyscall_linux_ppc64le.go
+++ b/unix/zsyscall_linux_ppc64le.go
@@ -979,7 +979,7 @@

// THIS FILE IS GENERATED BY THE COMMAND AT THE TOP; DO NOT EDIT

-func MemfdCreate(name string, flags uint) (fd int, err error) {
+func MemfdCreate(name string, flags int) (fd int, err error) {
var _p0 *byte
_p0, err = BytePtrFromString(name)
if err != nil {
diff --git a/unix/zsyscall_linux_riscv64.go b/unix/zsyscall_linux_riscv64.go
index b030fc8..6977f04 100644
--- a/unix/zsyscall_linux_riscv64.go
+++ b/unix/zsyscall_linux_riscv64.go
@@ -979,7 +979,7 @@

// THIS FILE IS GENERATED BY THE COMMAND AT THE TOP; DO NOT EDIT

-func MemfdCreate(name string, flags uint) (fd int, err error) {
+func MemfdCreate(name string, flags int) (fd int, err error) {
var _p0 *byte
_p0, err = BytePtrFromString(name)
if err != nil {
diff --git a/unix/zsyscall_linux_s390x.go b/unix/zsyscall_linux_s390x.go
index 4d7f1e9..2bfd3d0 100644
--- a/unix/zsyscall_linux_s390x.go
+++ b/unix/zsyscall_linux_s390x.go
@@ -979,7 +979,7 @@

// THIS FILE IS GENERATED BY THE COMMAND AT THE TOP; DO NOT EDIT

-func MemfdCreate(name string, flags uint) (fd int, err error) {
+func MemfdCreate(name string, flags int) (fd int, err error) {
var _p0 *byte
_p0, err = BytePtrFromString(name)
if err != nil {

To view, visit change 136296. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sys
Gerrit-Branch: master
Gerrit-Change-Id: Ifc4afacfbedb70f3818b23ed3ea468745bbdb455
Gerrit-Change-Number: 136296
Gerrit-PatchSet: 1
Gerrit-Owner: Tobias Klauser <tobias....@gmail.com>
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Tobias Klauser <tobias....@gmail.com>
Gerrit-MessageType: newchange

Gobot Gobot (Gerrit)

unread,
Sep 19, 2018, 10:34:17 AM9/19/18
to Tobias Klauser, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Brad Fitzpatrick, golang-co...@googlegroups.com

TryBots beginning. Status page: https://farmer.golang.org/try?commit=25551482

View Change

    To view, visit change 136296. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sys
    Gerrit-Branch: master
    Gerrit-Change-Id: Ifc4afacfbedb70f3818b23ed3ea468745bbdb455
    Gerrit-Change-Number: 136296
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tobias Klauser <tobias....@gmail.com>
    Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Tobias Klauser <tobias....@gmail.com>
    Gerrit-CC: Gobot Gobot <go...@golang.org>
    Gerrit-Comment-Date: Wed, 19 Sep 2018 14:34:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Gobot Gobot (Gerrit)

    unread,
    Sep 19, 2018, 10:35:38 AM9/19/18
    to Tobias Klauser, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Brad Fitzpatrick, golang-co...@googlegroups.com

    TryBots are happy.

    Patch set 1:TryBot-Result +1

    View Change

      To view, visit change 136296. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: sys
      Gerrit-Branch: master
      Gerrit-Change-Id: Ifc4afacfbedb70f3818b23ed3ea468745bbdb455
      Gerrit-Change-Number: 136296
      Gerrit-PatchSet: 1
      Gerrit-Owner: Tobias Klauser <tobias....@gmail.com>
      Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
      Gerrit-Reviewer: Gobot Gobot <go...@golang.org>
      Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
      Gerrit-Reviewer: Tobias Klauser <tobias....@gmail.com>
      Gerrit-Comment-Date: Wed, 19 Sep 2018 14:35:37 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Brad Fitzpatrick (Gerrit)

      unread,
      Sep 19, 2018, 10:58:23 AM9/19/18
      to Tobias Klauser, goph...@pubsubhelper.golang.org, Brad Fitzpatrick, Gobot Gobot, Ian Lance Taylor, golang-co...@googlegroups.com

      Patch set 1:Code-Review +2

      View Change

        To view, visit change 136296. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: sys
        Gerrit-Branch: master
        Gerrit-Change-Id: Ifc4afacfbedb70f3818b23ed3ea468745bbdb455
        Gerrit-Change-Number: 136296
        Gerrit-PatchSet: 1
        Gerrit-Owner: Tobias Klauser <tobias....@gmail.com>
        Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
        Gerrit-Reviewer: Gobot Gobot <go...@golang.org>
        Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
        Gerrit-Reviewer: Tobias Klauser <tobias....@gmail.com>
        Gerrit-Comment-Date: Wed, 19 Sep 2018 14:58:21 +0000

        Tobias Klauser (Gerrit)

        unread,
        Sep 19, 2018, 12:13:07 PM9/19/18
        to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Brad Fitzpatrick, Gobot Gobot, Ian Lance Taylor, golang-co...@googlegroups.com

        Tobias Klauser merged this change.

        View Change

        Approvals: Brad Fitzpatrick: Looks good to me, approved Tobias Klauser: Run TryBots Gobot Gobot: TryBots succeeded
        unix: change MemfdCreate flags parameter to int for all GOARCHes

        For some reason I didn't completely re-generate the zsyscall_linux_*
        files for all GOARCHes during review of CL 135915. Do so now such that
        the flags parameter is of type int on all GOARCHes.

        Change-Id: Ifc4afacfbedb70f3818b23ed3ea468745bbdb455
        Reviewed-on: https://go-review.googlesource.com/136296
        Run-TryBot: Tobias Klauser <tobias....@gmail.com>
        TryBot-Result: Gobot Gobot <go...@golang.org>
        Reviewed-by: Brad Fitzpatrick <brad...@golang.org>
        Gerrit-PatchSet: 2
        Gerrit-Owner: Tobias Klauser <tobias....@gmail.com>
        Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
        Gerrit-Reviewer: Gobot Gobot <go...@golang.org>
        Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
        Gerrit-Reviewer: Tobias Klauser <tobias....@gmail.com>
        Gerrit-MessageType: merged
        Reply all
        Reply to author
        Forward
        0 new messages