Using git notes instead of comment changing.

[Ivan Danilov]

I've just read about notes feature in git and it seems like very good option for git-tfs. Currently we are saving info inside comment thus changing commit's sha when checking it into TFS. Instead we could just add a note to it. And sha would remain the same.

So with the note we're marking commit as corresponding to TFS changeset without actually changing it. It can greatly simplify things because rcheckin will just go through ancestry-line without rebasing everything on each step. If new commits were detected in TFS - we have non-fast-forward situation and stop checkin-inig process in the same way git does without TFS.

For this to work bootstrap have to setup fetching/pushing '+refs/notes/tfs/*:refs/notes/tfs/*' in the repository config.

Does anyone could think of any potential problems with this approach?

[Matt Burke]

If I remember right, notes are a little cumbersome to push & pull.
That's probably the biggest issue I'd have with it.

Another option could be to use tags, but (as noted elsewhere) they
slow down certain interactions with git, especially shell
auto-completions.

> --
> You received this message because you are subscribed to the Google Groups
> "git-tfs-dev" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/git-tfs-dev/-/aXL3j1aJU_0J.
> To post to this group, send email to git-t...@googlegroups.com.
> To unsubscribe from this group, send email to
> git-tfs-dev...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/git-tfs-dev?hl=en.
>

[Ivan Danilov]

Pushing/pulling of notes could be hard (if I understood it correctly) if there're several actors who could change them - i.e. when they're edited and should be merged. In our conditions we could only create them. No editing should be here at all.