[geotools/geotools] 09eb82: Add regression test for bug GEOT-5036

0 views
Skip to first unread message

Andrea Aime

unread,
Apr 18, 2015, 1:14:03 PM4/18/15
to geotools...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/geotools/geotools
Commit: 09eb823d41bf81cb651febe0964246fecdd3159f
https://github.com/geotools/geotools/commit/09eb823d41bf81cb651febe0964246fecdd3159f
Author: Guido Grazioli <guido.g...@gmail.com>
Date: 2015-03-05 (Thu, 05 Mar 2015)

Changed paths:
A modules/unsupported/geojson/src/test/java/org/geotools/geojson/GEOT5036RegressionTest.java

Log Message:
-----------
Add regression test for bug GEOT-5036

The class GeoJSONUtil is using a shared static instance of SimpleDateFormat,
which is not thread-safe. Use of the class in a multithreaded environment
causes unexpected results and/or runtime exceptions.


Commit: 88661a8355d3df795149d47f09745dc099a169a5
https://github.com/geotools/geotools/commit/88661a8355d3df795149d47f09745dc099a169a5
Author: Guido Grazioli <guido.g...@gmail.com>
Date: 2015-03-05 (Thu, 05 Mar 2015)

Changed paths:
M modules/unsupported/geojson/src/main/java/org/geotools/geojson/GeoJSONUtil.java
M modules/unsupported/geojson/src/main/java/org/geotools/geojson/feature/FeatureTypeAttributeIO.java
M modules/unsupported/geojson/src/test/java/org/geotools/geojson/FeatureJSONExtendedTest.java
M modules/unsupported/geojson/src/test/java/org/geotools/geojson/GEOT5036RegressionTest.java

Log Message:
-----------
Fix bug GEOT-5036

Turn the static SimpleDateFormat into a ThreadLocal
contained instance. This option should be fast enough
(avoiding synchronisation) and does not introduce new
libraries which provide thread-safe formatters (like
joda or commons-lang-3) for this single task.


Commit: 3c74ee283b8d6e58fba16b2514ffbdc2bae76ff7
https://github.com/geotools/geotools/commit/3c74ee283b8d6e58fba16b2514ffbdc2bae76ff7
Author: Guido Grazioli <guido.g...@gmail.com>
Date: 2015-03-06 (Fri, 06 Mar 2015)

Changed paths:
M modules/unsupported/geojson/pom.xml
M modules/unsupported/geojson/src/main/java/org/geotools/geojson/GeoJSONUtil.java
M modules/unsupported/geojson/src/main/java/org/geotools/geojson/feature/FeatureTypeAttributeIO.java
M modules/unsupported/geojson/src/test/java/org/geotools/geojson/FeatureJSONExtendedTest.java
M modules/unsupported/geojson/src/test/java/org/geotools/geojson/GEOT5036RegressionTest.java

Log Message:
-----------
Revert use of ThreadLocal date formatters

Use FastDateFormat from commons-lang, which is threadsafe,
for formatting, and one-off disposable SimpleDateFormat for
parsing. commons-lang was already available in parent
dependencyManagement.


Commit: 081361c33925439687d9667c786eeeedeaa08c8a
https://github.com/geotools/geotools/commit/081361c33925439687d9667c786eeeedeaa08c8a
Author: Andrea Aime <andre...@gmail.com>
Date: 2015-04-18 (Sat, 18 Apr 2015)

Changed paths:
M modules/unsupported/geojson/pom.xml
M modules/unsupported/geojson/src/main/java/org/geotools/geojson/GeoJSONUtil.java
M modules/unsupported/geojson/src/main/java/org/geotools/geojson/feature/FeatureTypeAttributeIO.java
M modules/unsupported/geojson/src/test/java/org/geotools/geojson/FeatureJSONExtendedTest.java
A modules/unsupported/geojson/src/test/java/org/geotools/geojson/GEOT5036RegressionTest.java

Log Message:
-----------
Merge pull request #761 from guidograzioli/master

Fix bug GEOT-5036


Compare: https://github.com/geotools/geotools/compare/1423bcf9020a...081361c33925
Reply all
Reply to author
Forward
0 new messages