12 views
Skip to first unread message

heathmatlock

unread,
Mar 25, 2013, 9:12:22 PM3/25/13
to flot-...@googlegroups.com
I was just looking at this pull request on github:

https://github.com/flot/flot/pull/1003

Any idea why any of this code causes the Travis build to fail?

https://github.com/djamshed/flot/commit/3ae7177d0c286e91e0ddba06e152f79a3b73ae63




--
Heath Matlock
+1 256 274 4225

DNS

unread,
Mar 26, 2013, 1:10:14 PM3/26/13
to flot-...@googlegroups.com
Currently the Travis build only runs JSHint.  Since most of the Flot codebase doesn't pass this test at the moment, it is expected to fail; it doesn't necessarily reflect on the pull request itself.

We only adopted these code standards recently, and are waiting until after 0.8 is released to get existing code in line with them.
Reply all
Reply to author
Forward
0 new messages