Namespace is missing in reflection schema data

[Xun Liu]

I'm playing with flatbuffer reflection and noticed namespace info is not recorded in reflection.fbs

This means two tables with the same name but different namespaces will have the same name in Schema.objects making it impossible to locate a table's schema based on its non-qualified name. Shouldn't namespace be part of the object name so we can solve this problem? Any thoughts?

[mikkelfj]

On Monday, September 5, 2016 at 3:30:41 AM UTC+2, Xun Liu wrote:

I'm playing with flatbuffer reflection and noticed namespace info is not recorded in reflection.fbs

This means two tables with the same name but different namespaces will have the same name in Schema.objects making it impossible to locate a table's schema based on its non-qualified name. Shouldn't namespace be part of the object name so we can solve this problem? Any thoughts?

I agree. In the flatcc (for C) schemacompiler, the namespace is dot prefixed to every name, or left out to be compatible with the flatc (for C++) depending on a flag.

[Wouter van Oortmerssen]

Yup, we need to add that. Anyone want to make a PR? If not I'll get to it eventually.

--
You received this message because you are subscribed to the Google Groups "FlatBuffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to flatbuffers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Xun Liu]

I can work on a fix many in one or two weeks after i wrap up my current work.

--
You received this message because you are subscribed to a topic in the Google Groups "FlatBuffers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/flatbuffers/HzLe4L5LNnY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to flatbuffers+unsubscribe@googlegroups.com.

[Wouter van Oortmerssen]

That be great! Let me know how you do.