Votes missing in Virginia

[Daniel Roberts]

Someone brought an issue with votes on HB2 to our attention. I also looked through a half dozen bills and found another one missing votes.

HB2 does not include House vote on passage

http://openstates.org/va/bills/2016/HB2/

http://lis.virginia.gov/cgi-bin/legp604.exe?161+sum+HB2

HB193 does not include House votes on engrossment or passage

http://openstates.org/va/bills/2016/HB193/

http://lis.virginia.gov/cgi-bin/legp604.exe?161+sum+HB193

Is this a known issue and how widespread is it?

[Daniel Roberts]

Someone may have already noticed but looking through the code the problem is that the vote strip regular expression in use does not allow for an abstaining member count to be included in the vote name so the vote is skipped.

I have submitted a pull request for an update to the regular expression. I am not in a position to fully test this end to end with the project but I did test the regular expression in the python interpreter with the string combinations involved. 

https://github.com/sunlightlabs/openstates/pull/1116

Please consider merging and running any necessary processes to get these votes pulled into the data set.

Thank you.

[Andy Lo]

Hey Daniel,

Thanks for submitting a patch.  I had to modify the regex a little and added some additional processing, but if the tests check out, I should have a fix out today.

On Tuesday, May 10, 2016 at 3:00:30 PM UTC-4, Daniel Roberts wrote:

[Daniel Roberts]

I appreciate it!

[Daniel Roberts]

I see that a fix was committed. Is there an estimated time frame I can pass onto someone about when the votes will appear on openstates which we pull data from? Thanks

[Daniel Roberts]

I see it is there now. Thanks for your help! I hope to contribute more in the future.