changing the default solar metal mass fraction

[Britton Smith]

Hi everyone,

I'm sending this to both the Grackle and Enzo-dev lists.  I just issued a pull request to Grackle to update the value of the solar metal mass fraction to be consistent with Cloudy.  I figured this was the best choice as Cloudy was used to generate the metal cooling tables.

If you have any comments on the value I've chosen, please leave a comment on the pull request, which can be viewed here:

https://bitbucket.org/grackle/grackle/pull-request/16/updating-the-solar-metal-mass-fraction-to/diff

Britton

[Nathan Goldbaum]

What do you think about also updating the value used in Enzo and yt to match?

--
You received this message because you are subscribed to the Google Groups "Grackle Cooling Library Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to grackle-cooling-...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Britton Smith]

Yes, I think we should absolutely do that as well.  Once this has been accepted, I plan to issue PRs for enzo and yt, too.

[Brian O'Shea]

I agree 100% - it's critical for Enzo, Grackle, and yt to all agree what 'Solar metallicity' actually is.

[Britton Smith]

Additionally, if you are ok with the new value, please leave an approval on the PR so I know there's support.