Proposal: Highlight left/right differences in "Doctest failed" output
26 views
Skip to first unread message
Eric Watson
Apr 20, 2018, 11:19:20 AM4/20/18
to elixir-lang-core
Hi all,
I love how ExUnit highlights the differences between left and right values for failing tests. I wish that doctest output also had this highlighting. Is this a feature worth adding to ExUnit? It seems doable from a brief, uneducated scan of the code. I'd like to attempt if core agrees it's a good feature.
Cheers,
Eric
Kelvin Raffael Stinghen
Apr 20, 2018, 11:31:08 AM4/20/18
to elixir-l...@googlegroups.com
I’m +1 on this! :)
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/5f0e90a5-3ff3-465d-8b3c-a27941c30b4e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
José Valim
Apr 20, 2018, 11:54:35 AM4/20/18
to elixir-l...@googlegroups.com
A PR would definitely be welcome!
On Fri, Apr 20, 2018 at 5:31 PM, Kelvin Raffael Stinghen <kelvin....@gmail.com> wrote:
I’m +1 on this! :)
On Apr 20, 2018, at 17:19, Eric Watson <wasno...@gmail.com> wrote:
Hi all,I love how ExUnit highlights the differences between left and right values for failing tests. I wish that doctest output also had this highlighting. Is this a feature worth adding to ExUnit? It seems doable from a brief, uneducated scan of the code. I'd like to attempt if core agrees it's a good feature.Cheers,Eric--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/5f0e90a5-3ff3-465d-8b3c-a27941c30b4e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/63A3578D-99BC-4807-8DC3-585011FF26CC%40gmail.com.To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
Eric Watson
Apr 20, 2018, 12:44:46 PM4/20/18
to elixir-l...@googlegroups.com
Great, I’ll start a PR, thanks!
> On Apr 20, 2018, at 10:54 AM, José Valim <jose....@gmail.com> wrote:
>
> A PR would definitely be welcome!
>
>
>
> José Valim
> www.plataformatec.com.br
> Founder and Director of R&D
>
> On Fri, Apr 20, 2018 at 5:31 PM, Kelvin Raffael Stinghen <kelvin....@gmail.com> wrote:
> I’m +1 on this! :)
>
> Best,
> Kelvin Stinghen
> kelvin....@me.com
>
>> On Apr 20, 2018, at 17:19, Eric Watson <wasno...@gmail.com> wrote:
>>
>> Hi all,
>>
>> I love how ExUnit highlights the differences between left and right values for failing tests. I wish that doctest output also had this highlighting. Is this a feature worth adding to ExUnit? It seems doable from a brief, uneducated scan of the code. I'd like to attempt if core agrees it's a good feature.
>>
>> Cheers,
>>
>> Eric
>>
>> --
>> You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4KUBoixq53abHeDVX94Mgs%3DiSrm6LZnJEcM1ucXVyRXpg%40mail.gmail.com.
> On Apr 20, 2018, at 10:54 AM, José Valim <jose....@gmail.com> wrote:
>
> A PR would definitely be welcome!
>
>
>
> José Valim
> www.plataformatec.com.br
> Founder and Director of R&D
>
> On Fri, Apr 20, 2018 at 5:31 PM, Kelvin Raffael Stinghen <kelvin....@gmail.com> wrote:
> I’m +1 on this! :)
>
> Best,
> Kelvin Stinghen
> kelvin....@me.com
>
>> On Apr 20, 2018, at 17:19, Eric Watson <wasno...@gmail.com> wrote:
>>
>> Hi all,
>>
>> I love how ExUnit highlights the differences between left and right values for failing tests. I wish that doctest output also had this highlighting. Is this a feature worth adding to ExUnit? It seems doable from a brief, uneducated scan of the code. I'd like to attempt if core agrees it's a good feature.
>>
>> Cheers,
>>
>> Eric
>>
>> --
>> You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/5f0e90a5-3ff3-465d-8b3c-a27941c30b4e%40googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
> To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/63A3578D-99BC-4807-8DC3-585011FF26CC%40gmail.com.
>
> For more options, visit https://groups.google.com/d/optout.
>
>
>
> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
> You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
> To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4KUBoixq53abHeDVX94Mgs%3DiSrm6LZnJEcM1ucXVyRXpg%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages