Logging from handle_info

33 views
Skip to first unread message

Michał Muskała

unread,
Dec 26, 2016, 10:34:48 AM12/26/16
to elixir-l...@googlegroups.com
The change in 1.4 to log unhandled messages in handle_info is, in my opinion, a good one, that will help many developers in uncovering some of the issues in their code bases and libraries they use. 
That said, I'm not convinced that logging with error level is the right choice. It creates confusion in many places when things that are silent on 1.3 start suddenly "throwing errors" on 1.4. While I understand that those are not exceptions, from couple questions I've already seen here and there, it's not entirely obvious to many developers and they consider their apps "broken" because of that.
Maybe the log level should be revisited on this one? I think a warning instead of an error would be much more appropriate, at least initially - it could be switched to error in the next release, when people are more familiar with that issue and libraries are properly adjusted, and leaking messages are uncovered.

Michał.

José Valim

unread,
Dec 26, 2016, 10:42:09 AM12/26/16
to elixir-l...@googlegroups.com
Yes, please send a PR.



José Valim
Skype: jv.ptec
Founder and Director of R&D

--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/2fd664f4-14e9-402b-9b6c-14fb64673cd5%40Spark.
For more options, visit https://groups.google.com/d/optout.

Reply all
Reply to author
Forward
0 new messages