Sherpa/Romeo API

[Franziska Ackermann]

Dear list,

We've come across an error related to the Sherpa/Romeo API under Mirage and Mirage2, using DSpace 5.3.
It seems that the display of the whole "upload step" page fails when Sherpa/Romeo cannot find any copyright information for a journal.

Example:

• "Clinical Journal of Gastroenterology" in dc.title.alternative leads to a proper display of the upload page, incl. Sherpa/Romeo details.
• "Journal of Brain Science" in dc.title.alternative or "1341-5301" (same journal) in dc.identifier.issn leads to an error. The upload step page fails to be displayed correctly. A quick check on http://www.sherpa.ac.uk/romeo/ revealed that Sherpa/Romeo doesn't hold any copyright information for this journal.

Index: 0, Size: 0

Java stacktrace:
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
at java.util.LinkedList.checkElementIndex(LinkedList.java:555)
at java.util.LinkedList.get(LinkedList.java:476)
at org.dspace.app.xmlui.aspect.submission.submit.UploadStep.make_sherpaRomeo_submission(UploadStep.java:399)
at org.dspace.app.xmlui.aspect.submission.submit.UploadStep.addBody(UploadStep.java:254)
at org.dspace.app.xmlui.aspect.submission.StepTransformer.addBody(StepTransformer.java:145)
...
********

I tried to test this behaviour on the demo machine (http://demo.dspace.org/xmlui/), but the Sherpa/Romeo API is not enabled there. Feedback from repositories that have Sherpa/Romeo enabled would be highly appreciated.

Best regards,
Franziska Ackermann

[helix84]

Thank you for your report, it contained all information it should
contain. I filed a new bug into our Jira, you can watch the progress
there by subscribing to the issue:

https://jira.duraspace.org/browse/DS-2740


Regards,
~~helix84

Compulsory reading: DSpace Mailing List Etiquette
https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette

[Franziska Ackermann]

Hi helix,

Thank you for filing the bug and fixing it.

Regards,
Franziska Ackermann

[helix84]

On Wed, Sep 9, 2015 at 9:29 AM, Franziska Ackermann
<franziska...@uni-ulm.de> wrote:
> Thank you for filing the bug and fixing it.

If you were able to test the patch and confirm it's correct and
doesn't have any unintended consequences, it would be very helpful.
Thanks.

[Franziska Ackermann]

Hi,

I inserted the code and tested it. The two examples were

Example:

• "Clinical Journal of Gastroenterology" in dc.title.alternative leads to a proper display of the upload page, incl. Sherpa/Romeo details. => Test result: Still behaves as it should
  
• "Journal of Brain Science" in dc.title.alternative or "1341-5301" (same journal) in dc.identifier.issn leads to an error. The upload step page fails to be displayed correctly. A quick check on http://www.sherpa.ac.uk/romeo/ revealed that Sherpa/Romeo doesn't hold any copyright information for this journal. => Test result: No error, upload page is displayed correctly
  

However, further tests showed the following:

If you enter "Fakejournal" in dc.title.alternative, the upload page fails:

Java stacktrace: java.lang.NullPointerException at org.dspace.app.sherpa.submit.SHERPASubmitService.getISSNs(SHERPASubmitService.java:75) at org.dspace.app.sherpa.submit.SHERPASubmitService.hasISSNs(SHERPASubmitService.java:84) at org.dspace.app.xmlui.aspect.submission.submit.UploadStep.make_sherpaRomeo_submission(UploadStep.java:383) at org.dspace.app.xmlui.aspect.submission.submit.UploadStep.addBody(UploadStep.java:254) at org.dspace.app.xmlui.aspect.submission.StepTransformer.addBody(StepTransformer.java:145) at org.dspace.app.xmlui.wing.AbstractWingTransformer.startElement(AbstractWingTransformer.java:223) at sun.reflect.GeneratedMethodAccessor125.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

Interestingly, when you enter "FakeISSN" in dc.identifier.issn, the upload page is displayed correctly. This may be an issue unrelated to the bug fix, though.

Best regards,
Franziska Ackermann

[Franziska Ackermann]

Hi,

There might be another bug related to the Sherpa/Romeo API. I concerns Mirage, Mirage2, DSpace 5.3.
I observed that the upload page during submission fails when dc.title.alternative is enabled in config/spring/api/sherpa.xml and Sherpa/Romeo comes accross a journal title it doesn't know (e.g. "Journal ABC").

This doesn't happen in the demo repository, I presume because Sherpa/Romeo is enabled with the default configuration of /config/ spring/api/sherpa.xml (it uses dc.identifier.issn, not dc.title.alternative). The error above only occurs when Sherpa/Romeo takes its information from dc.title.alternative. An unnown ISSN in dc.identifier.issn doesn't cause any problems.

Repositories which use dc.title.alternative for Sherpa/Romeo (alternatively or additionally to dc.identifier.issn) will probably experience that the upload step fails when Sherpa/Romeo doesn't know the Journal Title. Can repositories which link Sherpa/Romeo with dc.title.alternative confirm this behaviour?

Error on the upload page:

Java stacktrace: java.lang.NullPointerException at org.dspace.app.sherpa.submit.SHERPASubmitService.getISSNs(SHERPASubmitService.java:75) at org.dspace.app.sherpa.submit.SHERPASubmitService.hasISSNs(SHERPASubmitService.java:84) at org.dspace.app.xmlui.aspect.submission.submit.UploadStep.make_sherpaRomeo_submission(UploadStep.java:383) at org.dspace.app.xmlui.aspect.submission.submit.UploadStep.addBody(UploadStep.java:254) at org.dspace.app.xmlui.aspect.submission.StepTransformer.addBody(StepTransformer.java:145) at org.dspace.app.xmlui.wing.AbstractWingTransformer.startElement(AbstractWingTransformer.java:223) at sun.reflect.GeneratedMethodAccessor125.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

Best regards,
Franziska Ackermann

--
You received this message because you are subscribed to the Google Groups "DSpace Technical Support" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dspace-tech...@googlegroups.com.
To post to this group, send email to dspac...@googlegroups.com.
Visit this group at http://groups.google.com/group/dspace-tech.
For more options, visit https://groups.google.com/d/optout.

[helix84]

Ah, I guess that explains it. I was wondering how you're getting your results.

Here are my testing results, just for dc.identifier.issn:

1645-8729 1341-5301

demo 5.3 OK NPE

5.3 OK NPE

5.3+patch OK OK, pub info shown, but no data

master OK OK, pub info shown, but no data

master+patch OK OK, pub info shown, but no data

So it seems my patch works and we can merge it because dc.title.alternative is a separate issue.