Question: how should "copy rule" behave?

[Dominik Sandjaja]

Hello,

we just got a request from a user who uses KIE Workbench 6.2.0 (CR2) with DSL-based rules.

The users use the "copy rule" feature quite often to create rules which are only slightly different from each other. The workflow is:
1. open the guided rule
2. click on "copy"
3. enter the name of the new rule (and maybe a checkin comment)
4. click on "create copy".
5. re-open the "Guided Rules (with DSL)" tree on the left
6. scroll down to the newly created rule
7. open the new rule in the editor

What they would like to have is to avoid the tedious steps 5.-7. Preferrably, the newly created, copied rule would automatically be opened as soon as the click in step 4. ("create copy") is done.

Before I file a feature request for this, how are the opinions among others here? Would this behavior help others as well?

Thanks in advance for any feedback
Dominik

[Dominik Sandjaja]

Hello,

since there seems to be either no interest in this functionality or there is no need for discussion, I will request the changed behavior as an enhancement.

Regards
Dominik

[Michael Anstis]

Hi Dominik,

I agree, in the absence of any objection it sounds like a good idea.

If you like I'd be happy to mentor you making the changes (they're not difficult) so you can submit a Pull Request - and get your required feature in sooner than otherwise is likely.

I'm manstis on #guvnordev on IRC if you want to pop by.

With kind regards,

Mike

--
You received this message because you are subscribed to the Google Groups "Drools Usage" group.
To unsubscribe from this group and stop receiving emails from it, send an email to drools-usage...@googlegroups.com.
To post to this group, send email to drools...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/drools-usage/42f4ecfc-016f-4ef3-9a6b-60c35c6e7bc6%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Dominik Sandjaja]

Hello,

this sounds like a good idea, I will give it a shot and contact you on IRC shortly (once I find my Github credentials ...)

I filed the ticket nevertheless, just for reference: https://issues.jboss.org/browse/GUVNOR-2151

Regards
Dominik

[Michael Anstis]

Great.

This is probably where you need to look first:

https://github.com/uberfire/uberfire-extensions/blob/master/uberfire-commons-editor/uberfire-commons-editor-client/src/main/java/org/uberfire/ext/editor/commons/client/menu/BasicFileMenuBuilderImpl.java#L198

You probably need to change "getCopySuccessCallback()" to also open the new Path

https://github.com/uberfire/uberfire-extensions/blob/master/uberfire-commons-editor/uberfire-commons-editor-client/src/main/java/org/uberfire/ext/editor/commons/client/menu/BasicFileMenuBuilderImpl.java#L248

Something like this is probably what's needed:

    private RemoteCallback<Path> getCopySuccessCallback() {

        return new RemoteCallback<Path>() {

            @Override

            public void callback( final Path path ) {

                busyIndicatorView.hideBusyIndicator();

                notification.fire( new NotificationEvent( CommonConstants.INSTANCE.ItemCopiedSuccessfully() ) );

                placeManager.goto( path );

            }

        };

    }

With kind regards,

Mike

To view this discussion on the web visit https://groups.google.com/d/msgid/drools-usage/9d23de36-b17f-4606-b691-68f0fa7da6d2%40googlegroups.com.