assertRaises() in django unittest framework doesn't catch exceptions

[Karantir]

Hi,
I use unittest framework and recently i've faced strange issue. I use
asserRaises() method to ensure that my model methods raises
appropriate exceptions. And methods raises, but asserRaises() doesn't
catch them, therefore i see an error with following traceback

<code>
======================================================================
ERROR: testCreate (logrus.documents.tests.testDocument)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\webservers\home\django\logrus\..\logrus\documents
\tests.py", line 59, in testCreate
self.assertRaises(RevisionNotStarted,
self.documents[0].fix_revision())
File "D:\webservers\home\django\logrus\..\logrus\documents
\models.py", line 109, in fix_revision
raise RevisionNotStarted
RevisionNotStarted
</code>

[Karantir]

And here is a bit of my testcase
[code]
self.assertRaises(RevisionNotStarted,
self.documents[0].fix_revision())
[/code]

[Marty Alchin]

Try removing the extra parentheses from your test case. assertRaises
expects to get a callable, which it can call within its own try/catch
block. You're instead calling the fix_revision() method before
assertRaises even has a chance to see the function. There's no way it
could catch the error in this case, so the error you reported is
natural.

[code]
self.assertRaises(RevisionNotStarted,
self.documents[0].fix_revision)
[/code]

-Gul