Buy 2 products from range A, get 50% off a product from range B

[Markus Bertheau]

Hi,

there's an example in the offers documentation at http://django-oscar.readthedocs.org/en/latest/ref/apps/offer.html#examples:

Buy 2 Lonely Planet books, get £5 off a Lonely Planet DVD

1. Create a range for Lonely Planet books and another for Lonely Planet DVDs
   
2. Use a count-based condition linking to the book range with a value of 2
   
3. Use a fixed discount benefit that links to the DVD range and has a value of 5.
   

Afaics, doing this if I buy 3 LP books, I can get two discounted LP DVDs. The reason is that after the Benefit consumed the discounted item (the first DVD), the Condition then reduces the number of lines it consumes by the number of lines the benefit already consumed. Thus, only one LP book is consumed, leaving 2 unconsumed ones. A second application of the offer will succeed.

I stumbled upon this thinking what it means for an offer not to consume items. One way to fix the above problem might be to track condition and offer consumptions separately.

Markus

[David Winterbottom]

I can't recreate this issue - I wrote a test to verify but it passed:

https://github.com/tangentlabs/django-oscar/commit/17851d4b66922f8d7e203e2b469040690c84a0db#diff-9262fa08d6a689e2cab11c4e01787afaR48

Am I missing something?

--
https://github.com/tangentlabs/django-oscar
http://django-oscar.readthedocs.org/en/latest/
https://twitter.com/django_oscar
---
You received this message because you are subscribed to the Google Groups "django-oscar" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-oscar...@googlegroups.com.
Visit this group at http://groups.google.com/group/django-oscar.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-oscar/2c4663c7-8433-4690-88bc-87fc35afc600%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

David Winterbottom
Technical Director

Tangent Snowball
84-86 Great Portland Street
London W1W 7NR
England, UK

[BugSpencer]

Il giorno martedì 15 luglio 2014 16:52:54 UTC+2, David Winterbottom ha scritto:

I can't recreate this issue - I wrote a test to verify but it passed:

...

Am I missing something?

I've been hit by this issue using latest master, so I can confirm it *IS* an issue.

Any chance offer refactor will be merged into master?