Any reason variants don't have images by default?

208 views
Skip to first unread message

Joshua Wedekind

unread,
Mar 18, 2015, 9:08:54 PM3/18/15
to django...@googlegroups.com
Hello,

Is there a reason why variants don't have an image tab in the dashboard by default? Will I blow anything up if I start adding images to variant products?

See:
https://github.com/django-oscar/django-oscar/blob/master/src/oscar/templates/oscar/dashboard/catalogue/product_update.html#L80


Maik Hoepfel

unread,
Mar 19, 2015, 11:10:41 AM3/19/15
to django...@googlegroups.com

Joshua,

No, it shouldn't blow anything up. we just don't have any logic of showing the variant product images on the parent product detail page. I think there's work towards that in a pending PR though. Didn't get a chance to look at it though. Please let us know how you get on!

Regards,

Maik

--
https://github.com/tangentlabs/django-oscar
http://django-oscar.readthedocs.org/en/latest/
https://twitter.com/django_oscar
---
You received this message because you are subscribed to the Google Groups "django-oscar" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-oscar...@googlegroups.com.
Visit this group at http://groups.google.com/group/django-oscar.
To view this discussion on the web, visit https://groups.google.com/d/msgid/django-oscar/4b0fa4c1-9c52-487b-b386-774446879937%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Joshua Wedekind

unread,
Mar 23, 2015, 6:27:50 AM3/23/15
to django...@googlegroups.com
Very good. I will probably make a simple jQuery widget that uses the variant images. When it's done, I'll post back.

John P

unread,
Mar 24, 2015, 11:28:07 AM3/24/15
to django...@googlegroups.com
Here's my PR: https://github.com/django-oscar/django-oscar/pull/1643

The way that it works is you associate all of the images with the parent, and then you create M2M links between the parent images and the variants.

I think this is a common enough use case that it should be included in Oscar in some form or another.

John

Joshua Wedekind

unread,
Apr 4, 2015, 1:04:48 AM4/4/15
to django...@googlegroups.com
Thanks, 

I'll check out your solution. And I'll turn on email updates so I know when someone has replied to me. ;)
Reply all
Reply to author
Forward
0 new messages