login_required for dashboard urls

[Asi Li]

I just noticed that all dashbaord urls don't have the login_required decorator.

Is this was done with intention or forgotten by mistake?

How I can wrap all dashboard urls with the login_required decorator the easy way?

10x

[David Winterbottom]

On 11 February 2015 at 19:55, Asi Li <asi...@gmail.com> wrote:

I just noticed that all dashbaord urls don't have the login_required decorator.

​That's not true in core Oscar - see here:

https://github.com/django-oscar/django-oscar/blob/master/src/oscar/apps/dashboard/app.py#L8-L11

Perhaps your customisations have removed this behaviour?​

 

Is this was done with intention or forgotten by mistake?

How I can wrap all dashboard urls with the login_required decorator the easy way?

10x

--
https://github.com/tangentlabs/django-oscar
http://django-oscar.readthedocs.org/en/latest/
https://twitter.com/django_oscar
---
You received this message because you are subscribed to the Google Groups "django-oscar" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-oscar...@googlegroups.com.
Visit this group at http://groups.google.com/group/django-oscar.
To view this discussion on the web, visit https://groups.google.com/d/msgid/django-oscar/a408ad4e-e5e5-4387-aac0-69eff727a72c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Asi Lichtenstein]

I have this permission but I was referring to inner dashbaord page.

There was 1 inner page that I've added that was produced server error if I tried to go their directly when I wasn't  signed in.

You received this message because you are subscribed to a topic in the Google Groups "django-oscar" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/django-oscar/jpxmtnJe2n4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to django-oscar...@googlegroups.com.

Visit this group at http://groups.google.com/group/django-oscar.

To view this discussion on the web, visit https://groups.google.com/d/msgid/django-oscar/CANaXhwksqcc4e0o3zOb_hKJmzHoKiFB4Jgbx0SfgWAwUvZhbVg%40mail.gmail.com.

[Asi Li]

got it sorted out, i will put it here maybe it would help other people:

when you want to grant only 1 permission make sure you use a list and not a tuple of one list.

David, is there a reason why there is a different between the 1 permission and above 1?

On Wednesday, February 11, 2015 at 10:51:52 PM UTC+2, Asi Li wrote:

I have this permission but I was referring to inner dashbaord page.

There was 1 inner page that I've added that was produced server error if I tried to go their directly when I wasn't  signed in.

On Wed, Feb 11, 2015 at 10:47 PM, David Winterbottom <david.win...@gmail.com> wrote:

On 11 February 2015 at 19:55, Asi Li <asi...@gmail.com> wrote:

I just noticed that all dashbaord urls don't have the login_required decorator.

​That's not true in core Oscar - see here:

https://github.com/django-oscar/django-oscar/blob/master/src/oscar/apps/dashboard/app.py#L8-L11

Perhaps your customisations have removed this behaviour?​

 

Is this was done with intention or forgotten by mistake?

How I can wrap all dashboard urls with the login_required decorator the easy way?

10x

--
https://github.com/tangentlabs/django-oscar
http://django-oscar.readthedocs.org/en/latest/
https://twitter.com/django_oscar
---
You received this message because you are subscribed to the Google Groups "django-oscar" group.

To unsubscribe from this group and stop receiving emails from it, send an email to django-oscar+unsubscribe@googlegroups.com.

Visit this group at http://groups.google.com/group/django-oscar.
To view this discussion on the web, visit https://groups.google.com/d/msgid/django-oscar/a408ad4e-e5e5-4387-aac0-69eff727a72c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
https://github.com/tangentlabs/django-oscar
http://django-oscar.readthedocs.org/en/latest/
https://twitter.com/django_oscar
---
You received this message because you are subscribed to a topic in the Google Groups "django-oscar" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/django-oscar/jpxmtnJe2n4/unsubscribe.

To unsubscribe from this group and all its topics, send an email to django-oscar+unsubscribe@googlegroups.com.

Visit this group at http://groups.google.com/group/django-oscar.