You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to django-d...@googlegroups.com
Hello,
I have posted an implementation/proof of concept to ticket 21644 (https://code.djangoproject.com/ticket/21644). The implementation is currently written as a mixin because I need to be able to use it now and I don't like maintaining a custom fork of django for my projects. If changed to update the base classes directly, the diff would be minimal.
I am happy to work on FormWizard improvements because they are particularly useful for some of my projects, but I haven't had much of a response. Since this is a contrib app bundled with django, I am hesitant to spend too much time on it without some sort of positive and/or constructive feedback from someone who can accept the changes.
On topic... the brief summary for #21644 is that this allows for "confirmation" steps in a formwizard that have access to the data submitted for previous steps. This is required for something like a checkout confirmation or anything where the user needs to be presented with data entered previously for acceptance to be meaningful. It was important to my use case that the wizard supports multiple confirmation steps. I've used a base class that confirmation forms should inherit from to detect when confirmation logic should be used. This allows for a backwards compatible opt-in approach.
Thanks,
Gordon
Tim Graham
unread,
May 26, 2014, 6:04:31 PM5/26/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to django-d...@googlegroups.com
My observation is that not many core developers seem interested in contrib.formtools these days. It was added by Adrian in 2006, but as far as I can see from the commit history, it hasn't received much love lately. If would be a good candidate for deprecation from Django itself, in my opinion.
Gordon
unread,
May 26, 2014, 6:51:13 PM5/26/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to django-d...@googlegroups.com
If we did split it out, would you be interested in being a maintainer?
Gordon
unread,
Jun 2, 2014, 2:27:07 PM6/2/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to django-d...@googlegroups.com
How would that work? Being part of contrib is a big plus for the app in many ways. I am not familiar with another app that was removed from contrib that would show an overview of the process and if it was successful.
Thomas Leo
unread,
Jun 2, 2014, 6:15:09 PM6/2/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to django-d...@googlegroups.com
The company I'm currently contracting for, makes heavy use of formtools, I'd be disappointed to see it go.
On Monday, May 26, 2014 6:04:31 PM UTC-4, Tim Graham wrote:
Tim Graham
unread,
Jun 2, 2014, 6:42:59 PM6/2/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
Carl: "-0 on formtools at this point for the same reason Jannis mentioned; it is actually actively maintained and used, and recently got some major improvements. In the abstract I do think that formtools is a fine candidate to be an external app rather than live in contrib, I just think we may as well start with the lower-hanging fruit here."
Jannis Leidel
unread,
Jun 3, 2014, 6:17:55 AM6/3/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to django-d...@googlegroups.com
Hi all,
I’ve actually changed my mind about this after we successfully pulled out django-localflavor (another niche contrib app) after some initial bumps. It’s now maintained under the Django umbrella org on Github: https://github.com/django/django-localflavor/
I would like to propose to do the same with formtools and release it as django-formtools.
- Move formtools out of contrib ASAP
- Allow more maintainers next to Django core devs
- Release individually from Django on PyPI as django-formtools
- Maintain backward compatibility similar to localflavor (in short: support the currently supported Django versions)
What do you think?
Carl, any change in opinion with regard to that as well?
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to django-d...@googlegroups.com
In my opinion, the reasoning for whether something should be a part of contrib is as follows:
- The application is of vital importance to the vast majority of Django sites, and needs to be done "correctly". Examples include auth and staticfiles, sessions.
- The application closely depends on internal, undocumented features of Django or is strongly intertwined with the core features like the ORM. Such applications are often very difficult to maintain their feature support across multiple versions of Django. Examples include gis, postgres, contenttypes.
To me, formtools meets neither of these requirements. It is not a 90%+ use case application like the admin or auth, and I don't believe there is much to it that is not workable outside of Django itself. It is useful, and does not deserve to be abandoned (like comments). Under github.com/django seems ideal to me.
Marc
Josh Smeaton
unread,
Jun 3, 2014, 8:53:07 AM6/3/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to django-d...@googlegroups.com
If formtools were to be pulled out and released separately, would that theoretically mean that releases could come more frequently than django core (provided there was community interest and maintenance)? I think that would be a decent carrot for community members that rely on its functionality.
Regards,
Jannis Leidel
unread,
Jun 3, 2014, 9:22:51 AM6/3/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
> If formtools were to be pulled out and released separately, would that theoretically mean that releases could come more frequently than django core (provided there was community interest and maintenance)? I think that would be a decent carrot for community members that rely on its functionality.
Yeah, that’d certainly be a possibility—assuming there is enough interest and maintenance work going on. For localflavor we’ve so far elected to do releases close to Django releases. But that’s mostly a practicality as the main maintainers (Erik and me) are both core devs.
Of course the same core values of maintenance like keeping backward compatibility etc would need to apply to an extracted app. That’s a feature we would need to be carefully look out for if formtools would be extracted.
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to django-d...@googlegroups.com
If we did split it out, would you be interested in being a maintainer?
I was against this at first but the more I've thought about it, I would be interested. Has anyone else expressed any interest or will I be the only maintainer?
I have another project coming up that will most likely use formwizard. What type of time frame would it take to get all of this set up if django decides to split formtools from contrib?