Fellow Reports - March 2018
Tim Graham
Week ending March 10, 2018
Following a snowstorm starting on March 2, my work was hampered last week by power and internet outages of five and seven days respectively. Things are back to normal as of Friday.
Triaged
-------
https://code.djangoproject.com/ticket/29179 - format_html() can falsely interpret a strack trace as a str.format replacement field (wontfix)
https://code.djangoproject.com/ticket/29190 - timezone.is_aware() raises unhandled exception when receiving datetime.date object as argument (invalid)
https://code.djangoproject.com/ticket/29183 - "cache" template tag should not render empty strings on failure (invalid)
https://code.djangoproject.com/ticket/29191 - Move the model name to the beginning of the page title for admin add/change/delete pages (wontfix)
Authored
----------
https://github.com/django/django/commit/8618271caa0b09daba39ff3b46567d33ae1e1d3a - Fixed CVE-2018-7536 -- Fixed catastrophic backtracking in urlize and urlizetrunc template filters.
https://github.com/django/django/commit/97b7dd59bb8d6163239061e2022153c3415d146d - Fixed CVE-2018-7537 -- Fixed catastrophic backtracking in django.utils.text.Truncator.
https://github.com/django/django/pull/9753 - Fixed #29165 -- Clarified how to load initial data with migrations.
Reviewed/committed
------------------
https://github.com/django/django/pull/9749 - Fixed #28981 -- Added an exception if GeoIP database can't be loaded from the path.
https://github.com/django/django/pull/9368 - Fixed #29178 -- Allowed Index.fields to accept a tuple.
https://github.com/django/django/pull/9763 - Fixed #29188 -- Fixed ContentFile.size after a write().
https://github.com/django/django/pull/9742 - Fixed #29180 -- Fixed a regression where migrations already in the plan were readded.Tim Graham
Week ending March 17, 2018
Triaged
-------
https://code.djangoproject.com/ticket/29214 - Invalid SQL when updating after annotating using subquery (accepted)
https://code.djangoproject.com/ticket/29200 - RadioSelect does not render its label in MultiWidget (accepted)
https://code.djangoproject.com/ticket/28975 - Skip automatic creation of postgis extension if it already exists (worksforme)
Authored
----------
https://github.com/django/django/pull/9782 - Fixed #29200 -- Fixed label rendering when using RadioSelect and CheckboxSelectMultiple with MultiWidget.
https://github.com/django/django/pull/8467 - Fixed #29227 -- Allowed BooleanField to be null=True. (resumed some work from months ago)
Reviewed/committed
------------------
https://github.com/django/django/pull/9775 - Fixed #29213 -- Fixed autocomplete widget's translations for zh-hans/zh-hant.
https://github.com/django/django/pull/9768 - Fixed #29199 -- Fixed crash when database user password contains @ sign on Oracle.
https://github.com/django/django/pull/9702 - Quoted field names in cache db backend SQL.
https://github.com/django/django/pull/9786 - Fixed #29221 -- Corrected admin's autocomplete widget to add a space after custom classes.
https://github.com/django/django/pull/9784 - Fixed #29219 -- Made admin filters use processed params rather than request.GET.
https://github.com/django/django/pull/9220 - Refs #28643 -- Added LTrim, RTrim, and Trim database functions.
https://github.com/django/django/pull/9680 - Fixed #29103 -- Removed bad 'b'-prefix added by MySQL's SchemaEditor.quote_value().
https://github.com/django/django/pull/9767 - Fixed #29184 -- Made TabularInline respect model form's Meta.labels and help_texts.
Tim Graham
Week ending March 24, 2018
Triaged
-------
https://code.djangoproject.com/ticket/29230 - Incorrect behavior of QuerySet.prefetch_related() in some circumstances during multilevel data prefetching (accepted)
https://code.djangoproject.com/ticket/29205 - MultiValueField ignores a required value of a sub field (accepted)
https://code.djangoproject.com/ticket/29237 - ModelAdmin.inlines cause a model to lose its primary key from a model field default (accepted)
https://code.djangoproject.com/ticket/29224 - Migration crashes deleting an index_together if there is a unique_together on the same fields (accepted)
https://code.djangoproject.com/ticket/29201 - Rendering issues when using ArrayField(models.BooleanField()) (invalid)
https://code.djangoproject.com/ticket/29189 - Allow customizing the CSS classes of the <tr>, <ul>, and <p> in Form.as_table(), as_ul(), and_p() (wontfix)
https://code.djangoproject.com/ticket/29238 - psycopg2.InterfaceError in sequential tests after HTTP 404 (invalid)
https://code.djangoproject.com/ticket/29256 - Need a save() call after assigning a many to many relation (invalid)
https://code.djangoproject.com/ticket/29249 - Add option to dumpdata to allow unicode JSON or YAML (accepted)
https://code.djangoproject.com/ticket/29247 - A custom blank value in model field choices doesn't work when using named groups (accepted)
Authored
----------
https://github.com/django/django/pull/9802 - Fixed #28718 -- Allowed password reset if a user's current password doesn't use an enabled hasher.
Reviewed/committed
------------------
https://github.com/django/django/pull/9798 - Refs #28643 -- Added LPad and RPad database functions.
https://github.com/django/django/pull/9796 - Fixed #29229 -- Fixed column mismatch crash when combining two annotated values_list() querysets with union(), difference(), or intersection().
https://github.com/django/django/pull/8975 - Refs #11278 -- Clarified RelatedManager differences between reverse one-to-many and many-to-many relations.
https://github.com/django/django/pull/9314 - Fixed #28514 -- Clarified docs about idempotence of RelatedManager.add().
https://github.com/django/django/pull/9805 - Increased test coverage for i18n template tags.
https://github.com/django/django/pull/7683 - Fixed #27533 -- Fixed inspectdb crash if a unique constraint uses an unsupported type.
https://github.com/django/django/pull/9789 - Fixed #23406 -- Allowed migrations to be loaded from .pyc files.
https://github.com/django/django/pull/9822 - Increased test coverage for various template tags.Tim Graham
Week ending March 31, 2018
Triaged
-------
https://code.djangoproject.com/ticket/29263 - Model.refresh_from_db() does not re-calculate annotation fields (invalid)
https://code.djangoproject.com/ticket/29260 - Remove UPDATE query when saving a new model instance with a primary key that has a default (accepted)
https://code.djangoproject.com/ticket/29265 - Docs about static files should explain benefits of using {% static %} template tag (fixed)
https://code.djangoproject.com/ticket/29266 - Cannot perform schema migrations without downtime using MySQL in strict mode (duplicate)
https://code.djangoproject.com/ticket/29268 - Support passing None to test Client and RequestFactory request methods for default content_type (accepted)
https://code.djangoproject.com/ticket/29273 - MultipleChoiceField incorrectly selects the empty value for an empty form (accepted)
Authored
----------
https://github.com/django/djangoproject.com/pull/821 - Switched dev TLD to localhost.
Reviewed/committed
------------------
https://github.com/django/django/pull/9824 - Fixed #29258 -- Added type checking for login()'s backend argument.
https://github.com/django/django/pull/9827 - Fixed #29148 -- Doc'd how to use get_or_create() with Q objects.
https://github.com/django/django/pull/9829 - Fixed #29245 -- Made autodetector treat field renames + db_column addition as RenameField.
https://github.com/django/django/pull/9833 - Fixed #29270 -- Fixed UserChangeForm crash if password field is excluded.
https://github.com/django/django/pull/9837 - Fixed #29275 -- Made assertFormError() output "(actual errors: none)" instead of "(actual errors: )".
https://github.com/django/django/pull/9834 - Fixed #29279 -- Added renderer argument to ModelForm.