Fellow Report - September 24, 2016

[Tim Graham]

I spent a few hours this week trying to develop a better understanding of the ORM by investigating some issues [0]. Along the way, I reviewed the coverage report for the relevant areas and submitted a few PRs to remove unused code. I hope I’ll have time to continue this effort. A nice outcome might be to develop some contributor-facing documentation to ease understanding and contributing to the ORM. Let me know if you have ideas about that or would be interested in helping with that.

[0] https://github.com/django/django/pull/6267 / https://github.com/django/django/pull/7289

Triaged

-------

https://code.djangoproject.com/ticket/27239 - Unexpected behavior on get_FIELDNAME_display when as int as value (duplicate)

https://code.djangoproject.com/ticket/27242 - Add get_object_or_none to django.shortcuts (duplicate)

https://code.djangoproject.com/ticket/27225 - Cache-Control's max-age doesn't match Expires for responses taken from cache (accepted)

https://code.djangoproject.com/ticket/27238 - Disable check_pattern_startswith_slash if settings.APPEND_SLASH=False (accepted)

https://code.djangoproject.com/ticket/27234 - Clarify the type of the django.server logger's 'request' extra context (accepted)

https://code.djangoproject.com/ticket/27246 -  Factor out input template in ClearableFileInput and document template class attributes (wontfix)

https://code.djangoproject.com/ticket/27245 - can't revert migration with index_together with one field (wontfix)

https://code.djangoproject.com/ticket/27231 - Initialize forms in ModelAdmin like View (i.e. add get_form_kwargs to contrib.admin) (wontfix)

https://code.djangoproject.com/ticket/27248 - Running migrations one-by-one fails after adding django.contrib.sites to INSTALLED_APPS. (fixed)

https://code.djangoproject.com/ticket/27253 - Use assertIsInstance() in test_force_text_lazy (invalid)

https://code.djangoproject.com/ticket/27255 - Change test runner to display full dotted name of test (duplicate)

https://code.djangoproject.com/ticket/27249 - IntegrityError when using ManyToManyField.add() with a value of incorrect type (duplicate)

https://code.djangoproject.com/ticket/27260 - Performance Issue because of LEFT OUTER JOIN instead the better INNER JOIN (invalid)

https://code.djangoproject.com/ticket/27240 - Allow passing custom parameters to formset forms in admin (duplicate)

https://code.djangoproject.com/ticket/27259 - ManyToOneRel.name uses relatemodelname instead of relatedmodelname_set (invalid)

https://code.djangoproject.com/ticket/27226 - Remove patch_response_headers()'s setting of the "Last-Modified" header (accepted)

https://code.djangoproject.com/ticket/27263 - Allow validators to short-circuit in form field validation (Someday/Maybe)

https://code.djangoproject.com/ticket/13161 - Avoid global registration of psycopg2 adapters/extensions (wontfix)

https://code.djangoproject.com/ticket/9394 - Reverse relation lookups with a multi-table inherited model produces extraneous queries (duplicate)

https://code.djangoproject.com/ticket/25049 - Oracle fails to change unique_together constraints due to case sensitivity (duplicate)

https://code.djangoproject.com/ticket/27265 - Using @admin.register causes failure when AdminModel constructor is overriden (invalid)

Authored

--------

https://github.com/django/django/pull/7268 - Refs #27025 -- Fixed ArrayField querying on Python 3.6.

https://github.com/andialbrecht/sqlparse/pull/292 - Fix test failure on Python 3.6. (later reverted as unnecessary, as a cpython ticket I opened resulted in cpython fixing the backwards-incompatibility.)

Reviewed/committed

------------------

https://github.com/django/django/pull/7241 - Fixed #27219 -- Changed cx_Oracle client encoding to AL32UTF8 to allow 4-byte characters.

https://github.com/django/django/pull/7269 - Fixed #27238 -- Disabled check_pattern_startswith_slash if settings.APPEND_SLASH.

https://github.com/django/django/pull/6735 - Fixed #26610 -- Added CitextField to contrib.postgres.

https://github.com/django/django/pull/7266 - Fixed #27158 -- Fixed positioning of admin's many-to-many widgets in rtl.css.

https://github.com/django/django/pull/7271 - Fixed #26210 -- Prevented SMTP backend from trying to send mail after a connection failure.

https://github.com/django/django/pull/7221 - Fixed #27159 -- Prevented pickling a query with an __in=inner_qs lookup from evaluating inner_qs.

https://github.com/django/django/pull/7255 - Fixed #27118 -- Made QuerySet.get_or_create()/update_or_create() error for a non-field in their arguments.

Reviews of core dev work

------------------------

https://github.com/django/django/pull/7264 - Fixed #27056 -- Allowed migrating geometry field dimension on PostGIS

https://github.com/django/django/pull/7279 - Fixed #27257 -- Fixed builtin text lookups on JSONField keys.