Should migrations have their imports sorted?

[Raphael Michel]

Hello,

some time ago, Django started to use isort to make sure imports are
formatted and sorted consistently throughout the codebase. I like this
very much, so I started adopting this practice for my own codebases.

However, today I noticed that when Django generates a migration, the
imports in the outputted python file are not necessarily sorted,
causing my checks to fail. In my case it was about these imports:

-from django.db import models, migrations
+from django.db import migrations, models

I had a short look at the source code, but being a novice to the
django.db subtree, I had no idea where exactly to look and I wanted to
ask here: Is this something trivial to fix or is it something that
cannot be solved without changing things very deeply?

This is, of course, absolutely not important, if not completely
irrelevant. However, if it would be a really easy fix, it could be a
nice bonus feature.

Cheers,
Raphael

[Tim Graham]

I think it's been addressed in 1.9 to at least some extent. See https://github.com/django/django/commit/7f20041bca43ca33f0a9617793f2af7ab07c3fab

[Raphael Michel]

Am Sat, 25 Jul 2015 16:32:21 -0700 (PDT)
schrieb Tim Graham <timog...@gmail.com>:

> I think it's been addressed in 1.9 to at least some extent. See
> https://github.com/django/django/commit/7f20041bca43ca33f0a9617793f2af7ab07c3fab

Oh, I didn't find that. Wonderful, sorry for the noise :)

Raphael