What is the standard travis/codecov configuration?

[Fabrice Pardo]

Hi,

After submitting pull request https://github.com/divio/djangocms-snippet/pull/45,

codecov/patch is complaining about  50% of diff hit (target 65.05%).

The problem is that render method was not covered before patch:

https://codecov.io/gh/divio/djangocms-snippet/src/master/djangocms_snippet/cms_plugins.py#L23

Now the pull request is marked with an infamous red cross, even it is (in my opinion) a not so bad pull request.

Is this red cross not so infamous, or is the travis/codecov configuration too strict?

-- 

Fabrice

 

[Angelo Dini]

Hello Fabrice,

given that the tests there are very basics, we do not weight the codecov report as a no go for not merging the PR.

If we see that you submitted a test alongside the PR, it's almost certain that it's gonna get merged.

Eventually also ping Paulo again for review and merge.

Cheers

Angelo

[Fabrice Pardo]

Thanks Angelo, you reassure me. I have the same problem with https://github.com/divio/djangocms-link/pull/136

Cheers

-- 

Fabrice