PSA: cricket::VideoFrame is dead, long live webrtc::VideoFrame!

[Niels Moller]

On Fri, Aug 19, 2016 at 10:12 AM, Niels Moller <ni...@webrtc.org> wrote:

The following classes are likely to be deleted:

   cricket::VideoFrame

   cricket::WebRtcVideoFrame

   cricket::CapturedFrame

   cricket::VideoFrameFactory

   cricket::WebRtcVideoFrameFactory

As of cl  https://codereview.webrtc.org/2411953002/, all these are now gone.

For backwards compatibility, the header files webrtc/media/base/videoframe.h and webrtc/media/engine/webrtcvideoframe.h still exist, and they define the corresponding classes to be aliases for webrtc::VideoFrame. Eventually, they will be deleted too.

Regards,

/Niels

[radioman . lt]

hip hip! ;}

[Rob Agar]

hooray!

[Idan Beck]

If these have been removed, what's the new approach to submit frames into a custom video capturer? 

[Niels Moller]

On Thu, Dec 14, 2017 at 8:28 PM, Idan Beck <idan...@gmail.com> wrote:
> If these have been removed, what's the new approach to submit frames into a
> custom video capturer?

The current way of doing a custom video capturer (or any other type of
video source) is to implement VideoTrackSourceInterface, declared in
api/mediastreaminterface.h.

If you want video adaptation, you may also want to have a look at the
AdaptedVideoTrackSource class, see
media/base/adaptedvideotracksource.h.

Regards,
/Niels

[Idan Beck]

Thanks Niels - I was doing this prior, but was using the CaputeredVideoFrame Our input data is in RGBA (coming out of an OpenGL texture) so I had a bit of work to figure out how to get it into an I420Buffer but looking through some of the unit testing code I found it and it's back up to snuff.  Thanks for the support, really appreciate it!  Best, Idan

--

---

You received this message because you are subscribed to a topic in the Google Groups "discuss-webrtc" group.

To unsubscribe from this topic, visit https://groups.google.com/d/topic/discuss-webrtc/k06BGD4gGOM/unsubscribe.

To unsubscribe from this group and all its topics, send an email to discuss-webrt...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/CAAO0x16k%3D95P%3DzoS2E90%2BG74vy%3Dt26atHSR_YJmmLWtPhd2FCg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

[Niels Moller]

On Mon, Dec 18, 2017 at 6:01 PM, Idan Beck <idan...@gmail.com> wrote:

Thanks Niels - I was doing this prior, but was using the CaputeredVideoFrame Our input data is in RGBA (coming out of an OpenGL texture) so I had a bit of work to figure out how to get it into an I420Buffer but looking through some of the unit testing code I found it and it's back up to snuff.

For conversion from OpenGL texture to I420, you may want to also have a look at https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/api/org/webrtc/YuvConverter.java?q=YuvConverter.java&sq=package:chromium&dr

Regards,

/Niels