SHA1_Init to EVP_DigestInit

[Martin Bonner]

We are upgrading our code base to the latest release of WebRTC.  We use a customized version of OpenSSL to perform the crypto for WebRTC.  This customized version doesn't (currently) have SHA1_Init.

If we were to update the WebRTC code to use EVP_DigestInit, would the pull request be likely to be accepted (subject to review etc)?

Note that https://www.openssl.org/docs/man1.1.0/crypto/SHA1_Init.html says:

"Applications should use the higher level functions EVP_DigestInit etc. instead of calling the hash functions directly."

Plan B of course is to add SHA1_init to our customized version.

[Justin Uberti]

Possibly - need more context. The page you cite suggests that none of the SHA_XXXX functions should be used. You can cc me on the code review.

--

---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrtc+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/96d1a30d-db73-478c-8b4d-4262bc4f9be1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.