Any applications depending on the webrtc video_render module?

[Niels Moller]

Hi all,

there's no longer any other code in webrtc itself which depends on the video_render module, i.e., base class webrtc::VideoRender, and the code under webrtc/modules/video_render.

So I'm considering deleting this code. If any of you are still using it, please speak up, at let me know which pieces you need. In particular, I'm not sure what mozilla/firefox is using?

As far as I'm aware, we have no tests for this code, and it's likely to get broken as we try to refactor various parts of webrtc. So in case any of this is kept, improved testing is needed.

Regards,

/Niels

[Ray Wang]

I just updated my render module from webrtc::VideoRender to RTCVideoRenderer  

So i'm no longer using these code. ^_^

在 2016年4月20日星期三 UTC+8下午10:51:45，Niels Moller写道：

[Devin Heitmueller]

Correct me if I'm wrong, but isn't the legacy video_render module in question still used by the peerconnection_client sample code (i.e. webrtc/examples/peerconnection/client)?

Devin

[Niels Moller]

On Fri, Apr 22, 2016 at 5:44 PM, Devin Heitmueller <dheitm...@kernellabs.com> wrote:

Correct me if I'm wrong, but isn't the legacy video_render module in question still used by the peerconnection_client sample code (i.e. webrtc/examples/peerconnection/client)?

I don't think so. peerconnection_client uses a class named "VideoRenderer", but that appears to be unrelated to webrtc::VideoRender.

Now I have a cl deleting the unused code out for review, see https://codereview.webrtc.org/1912143002/.

Regards,

/Niels