gclient sync errors

[William Cheung]

I was able to fetch the c++ webrtc libraries last month, but I am getting errors trying again today. Using VS2015. This is the output after gclient sync runs for 1 hour.

________ running 'C:\workspace\depot_tools\python276_bin\python.exe src/webrtc/build/gyp_webrtc.py -Dextra_gyp_flag=0' in 'c:\workspace\webrtc-checkout'

Updating projects from gyp files...

Traceback (most recent call last):

  File "src/webrtc/build/gyp_webrtc.py", line 128, in <module>

  File "src/webrtc/build/gyp_webrtc.py", line 122, in main

  File "c:\workspace\webrtc-checkout\src\build\vs_toolchain.py", line 248, in CopyVsRuntimeDlls

    _CopyRuntime(out_debug,          x86, "x86", debug=True)

  File "c:\workspace\webrtc-checkout\src\build\vs_toolchain.py", line 203, in _CopyRuntime

    _CopyRuntime2015(target_dir, source_dir, '%s140' + suffix, suffix)

  File "c:\workspace\webrtc-checkout\src\build\vs_toolchain.py", line 187, in _CopyRuntime2015

    source = os.path.join(source_dir, dll)

  File "C:\workspace\depot_tools\python276_bin\lib\ntpath.py", line 96, in join

    assert len(path) > 0

TypeError: object of type 'NoneType' has no len()

Error: Command 'C:\\workspace\\depot_tools\\python276_bin\\python.exe src/webrtc/build/gyp_webrtc.py -Dextra_gyp_flag=0' returned non-zero exit status 1 in c:\workspace\webrtc-checkout

Hook ''C:\workspace\depot_tools\python276_bin\python.exe' src/webrtc/build/gyp_webrtc.py -Dextra_gyp_flag=0' took 20.69 secs

Does anyone have any advice on how to get the latest webrtc libraries or having the same problem?

Thanks

[Christoffer Jansson]

+Henrik Kjellander do you have any suggestions?

--

---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrt...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/53ac430f-cc93-4172-a2c3-562fd96901d8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

/Chris

[Ivan Mezhebitckii]

I'm facing the same problem. I have both Visual studio 2013/2015 installed but neither

Set GYP_MSVS_VERSION=2015

fetch webrtc 

nor

Set GYP_MSVS_VERSION=2013

fetch webrtc

works properly. Seems like wrong source_dir  parameter is passed to  _CopyRuntime2015(target_dir, source_dir, dll_pattern, suffix) function in vs_toolchain.py script

[Henrik Kjellander]

At https://webrtc.org/native-code/development/prerequisite-sw/ there's a link to https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md where step 1 and 2 are needed. Have you done that? I suspect you may not have set DEPOT_TOOLS_WIN_TOOLCHAIN=0

--

---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrt...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/8a3c2af4-3739-44e6-98e5-3a0ee83d457c%40googlegroups.com.

[Ivan Mezhebitckii]

Yes, I've made the checkouts before without problems, so I had DEPOT_TOOLS_WIN_TOOLCHAIN=0 set as needed

пятница, 13 мая 2016 г., 8:45:03 UTC+2 пользователь Henrik Kjellander написал:

[Henrik Kjellander]

Can you do some debugging by editing src\build\vs_toolchain.py ? Like printing the source_dir etc?

I don't really know what this is, but it sounds like it could be a bug that should be reported to crbug.com. I'd like to know more first though.

To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/88086e85-3a83-4ce0-9c10-e3ad881729fa%40googlegroups.com.

[William Cheung]

Same here.

[Marcus Froeschl]

Hello Henrik,

this issue is happening for me as well during gclient sync. 

I do have Visual Studio 2015 installed, and the environment variable DEPOT_TOOLS_WIN_TOOLCHAIN is set to 0,

> Can you do some debugging by editing src\build\vs_toolchain.py ? Like printing the source_dir etc?

I added the requested log output, it seems like source_dir is None:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

D:\webrtc\webrtc-checkout\src>echo %DEPOT_TOOLS_WIN_TOOLCHAIN%

0

D:\webrtc\webrtc-checkout\src>python webrtc/build/gyp_webrtc.py

Updating projects from gyp files...

target_dir = D:\webrtc\webrtc-checkout\src\out\Debug, source_dir = None, dll_pattern = %s140d.dll, suffix = d.dll

Traceback (most recent call last):

  File "webrtc/build/gyp_webrtc.py", line 128, in <module>

    sys.exit(main())

  File "webrtc/build/gyp_webrtc.py", line 122, in main

    (x86_runtime, x64_runtime))

  File "D:\webrtc\webrtc-checkout\src\build\vs_toolchain.py", line 249, in CopyVsRuntimeDlls

    _CopyRuntime(out_debug,          x86, "x86", debug=True)

  File "D:\webrtc\webrtc-checkout\src\build\vs_toolchain.py", line 204, in _CopyRuntime

    _CopyRuntime2015(target_dir, source_dir, '%s140' + suffix, suffix)

  File "D:\webrtc\webrtc-checkout\src\build\vs_toolchain.py", line 188, in _CopyRuntime2015

    source = os.path.join(source_dir, dll)

  File "D:\tools\depot_tools\python276_bin\lib\ntpath.py", line 96, in join

    assert len(path) > 0

TypeError: object of type 'NoneType' has no len()

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Best regards,

Marcus

[Henrik Kjellander]

Thanks for the debugging. This is a bug introduced by myself in https://codereview.webrtc.org/1895713002, trying to satisfy the PyLint check. I'm sorry about that, I thought I tested the case when DEPOT_TOOLS_WIN_TOOLCHAIN=0.

I filed https://bugs.chromium.org/p/webrtc/issues/detail?id=5911 and fixed it in https://codereview.webrtc.org/1992813006/.

Can you verify it solves the problem?

[Emanuele Bizzarri]

Hi,
I tested:
set DEPOT_TOOLS_WIN_TOOLCHAIN=0
set GYP_DEFINES=component=shared_library
set GYP_MSVS_VERSION=2015
fetch webrtc

and now it is working again for me.
In last few days I had the same problems reported above, so I think you have fixed.

Thank you very much.

Emanuele

To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/7f5b721d-d3e0-43b2-be63-7381a053a86d%40googlegroups.com.

[Marcus Froeschl]

Hello Henrik,

thank you very much for the fix. I could confirm that everything works as expected now.

Best regards,

Marcus

[Henrik Kjellander]

No problem - I was the one breaking you in the first place. Don't hesitate to file a bug at bugs.webrtc.org if you run into issues like this.

To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/9e3172c1-41dd-46dd-9a80-cf0f1b3b5a0b%40googlegroups.com.

[Mark Roberts]

Hey Henrik,

Thanks for the fix. Any chance this could be back-ported to branch-heads/52? Should I open a ticket for it?

There are some other issues in addition to this one on branch-heads/52 that cause Windows builds to fail.

Mark

[Henrik Kjellander]

On Fri, May 27, 2016 at 8:04 AM, Mark Roberts <mrob...@twilio.com> wrote:

Hey Henrik,

Thanks for the fix. Any chance this could be back-ported to branch-heads/52? Should I open a ticket for it?

I have now merged it into the 52 branch in this commit: https://chromium.googlesource.com/external/webrtc/+/6fabd3d7de5cec8e39e3e6c68de61f9063503597

 

There are some other issues in addition to this one on branch-heads/52 that cause Windows builds to fail.

If there are more issues, please file a bug and provide as much details as you can.

 

To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/e1d50c1b-443b-4d1f-9b71-09da8f39bab5%40googlegroups.com.