Taking a screenshot with DesktopCapturer

[g...@chromium.org]

Hi folks. I find that my use of DesktopCapturer to grab a screenshot sometimes returns only a portion of the screen. It's possible that I'm getting data from the frame and encoding it into a JPG improperly, bu it's also entirely possible that I'm holding the DesktopCapturer itself wrong. The odd thing is that it works perfectly on my local machine -- it's only on some Chromium bots (where I really need it to work) that it returns a partial screen. Could someone who knows how this stuff work take a look at this CaptureScreen() implementation and the use of PNGCodec::EncodeBGRASkBitmap down here and let me know if there's something obviously wrong with it?

Many thanks.

Greg

[anil2...@gmail.com]

I hv seen DesktopCapturer does not intialized with exact resolution of screen on some machine.

that might be the reason of partial screen in your case as it might have been initialized with less width and height of the machine resolution.

[g...@chromium.org]

Thanks. How can I tell if that's happening, and how can I fix it?

In the latest snapshots I've looked at, the resulting image is all black. This is not so helpful. :-(

I would really appreciate some eyes on https://cs.chromium.org/chromium/src/chrome/test/base/save_desktop_snapshot_win.cc?type=cs&q=file:save_desktop_snapshot_win.cc&sq=package:chromium&l=1 to see if there's something obvious that I'm missing.