Questions about code reviews and static analysis tools for TU Delft research

[Radjino Bholanath]

Hi everyone,

I'm doing research on code reviews and static analysis tools at the SERG group (http://swerl.tudelft.nl/bin/view/Main/WebHome) of the Delft University of Technology. Currently, we want to give an overview of the usage of code review and static analysis tools in open source projects. Therefore, I would be very happy to know a little bit more about how code reviews are used in Diaspora and if (and maybe how) static analysis tools are used. I have a couple of questions for anyone willing to answer:

1. Do all developers (contributors and core developers) have to submit a code review for every change? I’m asking because many projects only review changes made by contributors.

2. Which code review tools are used? Just GitHub pull requests, or other tools as well?

3. Are static analyzers used? If they are used:

a. Is passing the checks of the static analyzers necessary for a change to be accepted?

b. Which static analyzers are used?

Thanks,

Radjino

[Jason Robinson]

Hi Radjino,

Some answers inline below.

On 04.02.2015 16:36, Radjino Bholanath wrote:

Hi everyone,

I'm doing research on code reviews and static analysis tools at the SERG group (http://swerl.tudelft.nl/bin/view/Main/WebHome) of the Delft University of Technology. Currently, we want to give an overview of the usage of code review and static analysis tools in open source projects. Therefore, I would be very happy to know a little bit more about how code reviews are used in Diaspora and if (and maybe how) static analysis tools are used. I have a couple of questions for anyone willing to answer:

1. Do all developers (contributors and core developers) have to submit a code review for every change? I’m asking because many projects only review changes made by contributors.

Yes all developers are subject to code review, regardless of their status. Code review is not limited to core developers - anyone can participate. But someone must review each patch or feature. Quite often many jump in :)

2. Which code review tools are used? Just GitHub pull requests, or other tools as well?

GitHub pull requests.

3. Are static analyzers used? If they are used:

a. Is passing the checks of the static analyzers necessary for a change to be accepted?

b. Which static analyzers are used?

No other tools used.

Thanks,

Radjino

--
You received this message because you are subscribed to the Google Groups "diaspora-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to diaspora-dev...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
-----
Br,
Jason Robinson
https://jasonrobinson.me

[Radjino Bholanath]

Thanks for answering Jason, I appreciate it.