Crazy Quotes!

[justaguy]

var cond = 'yes',
lineX = '',
oid = 7;

if (cond == 'Yes') {lineX =
"<br><input type=button value=Update onclick=doSomething("+oid+")>" +
"&nbsp;&nbsp;&nbsp;&nbsp;" +
"<a href=mycomment.cfm?Number="+oid+" target=_new>Comment</a>";
}

var doSomething = function(oid) {
console.log(oid);
}


Of the above, the quotes for the line with "onclick=soSomething()..." drives me nuts. How to fix them?

Thanks.

[Evertjan.]

justaguy <lichun...@gmail.com> wrote on 23 Jul 2017 in
comp.lang.javascript:

'use strict'; // add this for better debugging

> var cond = 'yes',

var cond = 'Yes'

// error[1]: case sensitive Yes

> lineX = '',
> oid = 7;
>
> if (cond == 'Yes') {lineX =
> "<br><input type=button value=Update onclick=doSomething("+oid+")>"

"<br><input type=button value=Update "
+ "onclick='doSomething("+oid+");'"

// error[2]: onclick needs [here single-]quoted content

> + "&nbsp;&nbsp;&nbsp;&nbsp;" +
> "<a href=mycomment.cfm?Number="+oid+" target=_new>Comment</a>";
> }
>
> var doSomething = function(oid) {
> console.log(oid);
>}

document.write(lineX);

// error[3]: you need the string to be inserted

>
> Of the above, the quotes for the line with "onclick=soSomething()..."
> drives me nuts. How to fix them?

You could easily have found this out by using the internal debugger
of your browser [I used Google-Chrome]:

<http://hannivoort.org/test/CrazyQuotes.jpg>

--
Evertjan.
The Netherlands.
(Please change the x'es to dots in my emailaddress)

[justaguy]

On Sunday, July 23, 2017 at 4:51:12 AM UTC-4, Evertjan. wrote:
> wrote on 23 Jul 2017 in
> comp.lang.javascript:
>
> 'use strict'; // add this for better debugging
>
> > var cond = 'yes',
>
> var cond = 'Yes'
>
> // error[1]: case sensitive Yes
>
> > lineX = '',
> > oid = 7;
> >
> > if (cond == 'Yes') {lineX =
> > "<br><input type=button value=Update onclick=doSomething("+oid+")>"
>
> "<br><input type=button value=Update "
> + "onclick='doSomething("+oid+");'"
>
> // error[2]: onclick needs [here single-]quoted content
>
> > + "&nbsp;&nbsp;&nbsp;&nbsp;" +
> > "<a href=mycomment.cfm?Number="+oid+" target=_new>Comment</a>";
> > }
> >
> > var doSomething = function(oid) {
> > console.log(oid);
> >}
>
> document.write(lineX);
>
> // error[3]: you need the string to be inserted
>
> >
> > Of the above, the quotes for the line with "onclick=soSomething()..."
> > drives me nuts. How to fix them?
>
> You could easily have found this out by using the internal debugger
> of your browser [I used Google-Chrome]:
>

Thanks. But three things:
(1) The oid value needs to a string, ie, "NSS-892-A-233".
(2) Probably the ending ">" was missed in your
[ + "onclick='doSomething("+oid+");'" ] line
(3) For Chrome internal debugger, were you referring to dev tool's console tab?

[Julio Di Egidio]

That code is just "ugly": the advice really is manipulate the DOM instead.

That said, it is not even just about escaping quotes within quotes: html
attributes should be html-encoded (no built-in function to do this, anyway
there are only 4 characters to escape: ", <, >, and &), plus url parameters
should be url-encoded (use encodeURIComponent there).

Anyway, assuming your attributes (your oid in particular) need no encoding,
here is how a single-quoted string looks like:

'<br><input type="button" value="Update" ' +
'onclick="doSomething(&quot;' + oid + '&quot;)">' +

'&nbsp;&nbsp;&nbsp;&nbsp;' +

'<a href="mycomment.cfm?Number=' + oid + '" target="_new">Comment</a>'

And here is the double-quoted one, for comparison:

"<br><input type=\"button\" value=\"Update\" " +
"onclick=\"doSomething(&quot;" + oid + "&quot;)\">" +

"&nbsp;&nbsp;&nbsp;&nbsp;" +

"<a href=\"mycomment.cfm?Number=" + oid + "\" target=\"_new\">Comment</a>"

Not tested, there may be typos: but you get the picture...

HTH,

Julio

[Evertjan.]

justaguy <lichun...@gmail.com> wrote on 23 Jul 2017 in

You did specify a number value.
Is that reason to say "thanks, but" ???

>> > oid = 7;

var oid = '"NSS-892-A-233"';

> (2) Probably the ending ">" was missed in your
> [ + "onclick='doSomething("+oid+");'" ] line

You are unshure?

> (3) For Chrome internal debugger, were you referring to dev tool's
> console tab?

Why did you skip my link? The link gives the answer.

[justaguy]

Yes, it works. So, lesson learned: the key here is to use the
&quot; in html format. Thought I tried to '" + oid + "' to no avail.

Thanks.

[justaguy]

On Sunday, July 23, 2017 at 11:24:47 AM UTC-4, Evertjan. wrote:
> justaguy wrote on 23 Jul 2017 in

The most forgivable thing in the world is a typo type of omission !

> > (3) For Chrome internal debugger, were you referring to dev tool's
> > console tab?
>
> Why did you skip my link? The link gives the answer.

Sorry, I missed it. Thanks.

[Julio Di Egidio]

Or you could have used single-quotes there, since single-quotes need not be
html-encoded:

'onclick="doSomething(\'' + oid + '\')">' +

or:

"onclick=\"doSomething('" + oid + "')\">" +

Still a terrible approach... ;)

Julio

[justaguy]

Ok, thanks.