github.com/cockroachdb/cockroach is no longer a buildable Go package

[Nikhil Benesch]

To reduce confusion for new users who attempt to run

    $ go get github.com/cockroachdb/cockroach

the top-level github.com/cockroachdb/cockroach package no longer contains any Go files. 

Where previously these users would get an error like

   pkg/sql/lex/predicates.go:60:14: undefined: reservedKeywords

which they often interpreted as a bug in the build system, they'll now get this error:

    can't load package: package github.com/cockroachdb/cockroach: no Go

files in GOPATH/src/github.com/cockroachdb/cockroach

Hopefully that error is less scary and spurs them to look up the build documentation, where they'll learn to use 'make build' instead of 'go build'.

This will probably have no impact on your development setup, but Ben has pointed out that some Go editor plugins allow you to configure a restricted "scope" of packages to analyze, like the Emacs Guru plugin. If you're using such an editor, and your scope was previously configured to "github.com/cockroachdb/cockroach", you'll probably need to update the scope to either the new entry point, "github.com/cockroachdb/cockroach/pkg/cmd/cockroach", or add a wildcard to the end, as in "github.com/cockroachdb/cockroach/..."

You can find the PR, which is presently working its way through the Bors queue, here: https://github.com/cockroachdb/cockroach/pull/25325

Nikhil

[Andrei Matei]

I believe this broke my Vim's :mak command, which used to run :!go build .

Does anyone happen to have a solution for me for building from Vim such that the quickfix list is populated with compilation errors? The vim-go plugin has a :GoBuild command, but that only builds the current file's package.

--
You received this message because you are subscribed to the Google Groups "CockroachDB" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cockroach-db+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cockroach-db/CAA-gNqJ_Ri9drY5JgGwSOvUyHNKCv5AuVo%2ByECQnowZy977nQg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Radu Berinde]

Change it to do `go build ./pkg/cmd/cockroach`

-Radu

To view this discussion on the web visit https://groups.google.com/d/msgid/cockroach-db/CAPqkKgmeYgvrh4areFUZ2gxX-E9-BoardaPLqFzR_jFJdJdfZA%40mail.gmail.com.

[Andrei Matei]

Thanks. For others, I figured out that the command's behavior was coming from

autocmd Filetype go set makeprg=go\ build\ .