Clojure 1.7 and Counterclockwise

[Laurent PETIT]

Hello,

I have tested Counterclockwise with Clojure 1.7.

There is a problem in Compiler.java, when getting system provided compiler options.

The OSGi environment is storing key/value pairs whose value is not of type String. This causes the cast to String here ( https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/Compiler.java#L260 ) to throw a ClassCastException.

Please don't ask me why OSGi is doing such a silly thing, I just have no idea.

What I know is that CCW cannot work with Clojure 1.7 without fixing it (that is, adding an explicit instanceof String check before the cast).

I have not tested other OSGi environments, but it would be possible that those also have the problem.

May I open an issue on JIRA and provide a patch?

--

Laurent Petit

[Laurent PETIT]

Here is the fix I would like to propose:

https://github.com/laurentpetit/clojure/commit/715516eee13a28026c6e9bb9270c847897f07e4a

--

Laurent Petit

[Laurent PETIT]

I have created an issue for this in JIRA, and attached a patch:

http://dev.clojure.org/jira/browse/CLJ-1717

Please note that without this patch applied, Counterclockwise cannot use Clojure 1.7 internally. This forces me to use a patched version of Clojure, which is unfortunate.

--

Laurent Petit

[Alex Miller]

Thanks, I'm checking with Rich.

--
You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to clojure-dev...@googlegroups.com.
To post to this group, send email to cloju...@googlegroups.com.
Visit this group at http://groups.google.com/group/clojure-dev.
For more options, visit https://groups.google.com/d/optout.