build.clojure.org and JDK 1.6

[Ryan Senior]

I have pushed up some new data.xml code [1] that uses the JDK 1.6 included XML pull parser.  Users of JDK 1.5 can use this code, they just need to add a dependency on StAX (I talk about this here [2]).  This dependency is something the user adds to their pom.xml/project.clj file, and is not listed as a dependency in data.xml.  

It looks like the data.xml build on build.clojure.org currently uses JDK 1.5, which causes the build to fail.  What is the best way to fix this problem?  Is using JDK 1.6 for data.xml an option?  I can add a StAX dependency to the data.xml pom, but this would be an external dependency (which [3] says to avoid) and is not needed for 1.6+.

-Ryan

[1] https://github.com/clojure/data.xml/commit/ec26f01f5754190c88d6c5c3b097c5fc87c1d9f4

[2] https://github.com/clojure/data.xml/blob/master/jdk_15_readme.txt

[3] http://dev.clojure.org/display/design/Contrib+1.0.0+Releases

[Stuart Sierra]

We've been focused on 1.5 as the primary build target for the widest possible compatibility.

I'm OK with moving data.xml to JDK 1.6, especially since 1.5 users still have a workable option by adding a Stax library. I prefer that to adding a dependency to data.xml.

The build config generator will need some tweaking (github.com/clojure/build.ci)

-S

[Ryan Senior]

I added something to specify the JDK per project here: https://github.com/senior/build.ci/commit/19a960e424b633deb080fdd91b2d08643992197e .

Was that what you were thinking?  If it looks good I can push it to the central repo, but I don't think I have access to hudson.

-Ryan

-S

--
You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
To view this discussion on the web visit https://groups.google.com/d/msg/clojure-dev/-/_k-9h4YpWNQJ.
To post to this group, send email to cloju...@googlegroups.com.
To unsubscribe from this group, send email to clojure-dev...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/clojure-dev?hl=en.

[Stuart Sierra]

This is close- thanks for working on it. I'd like to specify the JDK
*version* rather than a specific JDK by name. The names are actually
defined in the main Hudson configuration. So somewhere we'd have a map
like this:

{"1.5" "Sun JDK 1.5"
"1.6" "Sun JDK 1.6"
"1.7" "Oracle JDK 1.7"
...}

Then for a particular project we could say :jdk-version "1.6" with 1.5
being the default.

Thanks,
-S

[Stuart Sierra]

There's another thing I'd want to check: sometimes JARs built with JDK
1.6 contain metadata that prevents them from being loaded by 1.5 JDKs,
even if they are bytecode-compatible with 1.5. The contrib parent POM
specifies 1.5, so maybe that's good enough. But I'd like someone to
test it first.

-S

[Ryan Senior]

Added a vendor independent JDK version here: https://github.com/senior/build.ci/commit/8ff1ac83d6b5f9fcdc728a1cd3db557d6b696bd0

I just tested a 1.6 built data.xml JAR on a Sun 1.5 JDK.  Worked without any issues.

-Ryan

[Sean Corfield]

Has there been any forward motion on this? (10 days ago)

Seems we should have had at least one OSS Friday back at HQ that could
have addressed the build issue... :)

[Stuart Sierra]

nope, busy with other stuff. it's in the queue.
-S

[Stuart Sierra]

Applied Ryan's patch to build.ci. Rebuilding Hudson configs now. Next will test build of data.xml and release if it works.

There is currently no owner for data.xml in Hudson. Who can take that on?

-S

[Ryan Senior]

I can take that on.  Does it just involve making releases, fixing build failures etc?

-S

--
You received this message because you are subscribed to the Google Groups "Clojure Dev" group.

To view this discussion on the web visit https://groups.google.com/d/msg/clojure-dev/-/ASXpc-lziGgJ.

[Stuart Sierra]

yes. Do you have a build.clojure.org account? If not, send me a private message with your preferred email address and I'll create an account for you.
-S