Adding optional specs to contrib libraries?
Sean Corfield
I went ahead and added a first cut of a spec to clojure.java.jdbc in an optional namespace:
https://github.com/clojure/java.jdbc/blob/master/src/main/clojure/clojure/java/jdbc/spec.clj
The tests attempt to require this and instrument the main namespace:
https://github.com/clojure/java.jdbc/blob/master/src/test/clojure/clojure/java/test_jdbc.clj#L27-L31
When running the tests on 1.9.0, this brings the specs into play and checks all calls. When running on earlier versions, nothing extra is done.
Sean Corfield -- (904) 302-SEAN
An Architect's View -- http://corfield.org/
"Perfection is the enemy of the good."
-- Gustave Flaubert, French realist novelist (1821-1880)
Sean Corfield
Why does the build process try to compile all the namespaces on all versions?
"If you're not annoying somebody, you're not really alive."
-- Margaret Atwood
se...@corfield.org
I updated the clojure.java.jdbc pom.xml to override the parent clojure-compile executions to suppress compilation for now, so I have a passing build phase. I believe it should be possible to enable compilation just for Clojure 1.9.0 via conditional profiles in Maven but I’m not sure I want to put in that much effort. At least now I should be able to push a release so folks can play with this…
…which begs the question, java.jdbc is at 0.6.1 now – if I make a release with an optional spec namespace, it’s technically backward compatible so 0.6.2 seems reasonable but… would 0.7.0 be a more sensible release version?
(I’m not planning to release a new version before we’ve had this discussion around Contrib libraries and clojure.spec but I’d like to include versioning in that discussion)
