Performance of JavadocTagContinuationIndentation, AtclauseOrder, NonEmptyAtclauseDescription etc.

[Csaba Kozák]

Hi!

We just switched to CS 6.5 from 5.8. I tried to enable the:

JavadocTagContinuationIndentation, AtclauseOrder, NonEmptyAtclauseDescription and SingleLineJavadoc

checks.

However i noticed that the CS execution increased from 4 seconds to 44 seconds on this codebase.
Is this normal? Should these checks need this much execution time?
We already have JavadocStyle, JavadocVariable, JavadocMethod and JavadocType and lots of other non-JavaDoc checks
and they running within the 4 seconds execution time.

Regards,
Csaba

[Michal Kordas]

Hi Csaba,

After investigation I've found that AtclauseOrder is the check with performance problem. Ticket created: https://github.com/checkstyle/checkstyle/issues/1064

Thanks for reporting,
Michal Kordas

--
You received this message because you are subscribed to the Google Groups "checkstyle" group.
To unsubscribe from this group and stop receiving emails from it, send an email to checkstyle+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Csaba Kozák]

Hi Michał,

Thanks for the quick answer!

I also enabled these checks individually, and i think not just AtclauseOrder is slow:
with AtclauseOrder: 44 sec
with JavadocTagContinuationIndentation: 60 sec
with NonEmptyAtclauseDescription: 52 sec
with SingleLineJavadoc: 53 sec

Instead of the normal 4 sec check time. I guess both of these are using a same routine which is responsible for the performance problem.

Regards,
Csaba

[Roman Ivanov]

Here is explanation of the performance issue: https://github.com/checkstyle/checkstyle/issues/1064#issuecomment-100697131​