Travis CI Build does not pass

[Bhavik Patel]

Hi,

I am working on issue 20. I made some changes and all UTs are also passed. but Travis build failed. can any developer help to solve this Travis CI build error. here is the link for log:

https://travis-ci.org/checkstyle/checkstyle/jobs/49872445

Thanks,

Bhavik.

[Ruslan Diachenko]

The problem appears on a validation stage:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.7:run (ant-phase-verify) on project checkstyle: An Ant BuildException has occured: The following error occurred while executing this line:
[ERROR] /home/travis/build/checkstyle/checkstyle/config/ant-phase-verify.xml:35: Checkstyle failed: Got 80 errors and 0 warnings.

And here's why: when you fixed FinalLocalVariable check it started working as expected. This check is included in checkstyle/config/checkstyle_checks.xml. The last stage of Checkstyle's maven build is running Checkstyle on its own sources and if there are violations the build fails.

From the travis log:

...
[checkstyle] /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/filters/CSVFilter.java:94:24: Variable 'filter' should be declared final.
[checkstyle] /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilter.java:447:18: Variable 'tag' should be declared final.
[checkstyle] /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilter.java:475:34: Variable 'eleont' should be declared final.
[checkstyle] /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilter.java:489:24: Variable 'comment' should be declared final.

It means that you have to fix FinalLocalVariable check's violations in Checkstyle sources in order so maven build was successful.