First experience in GSoC

[mikhailo...@gmail.com]

Hello, team :)

Earlier I did not participate in such projects, but I have experience in Java development. I got training on Java Core courses. In my training repository installed Checkstyle tests and Gradle in GitHub for the control of styles of all projects.

Besides, I studied Java for Android and wrote from scratch a small application https://github.com/MikhailovOlegM/Time-Optimazer.

I read the messages of other people and noticed that you are give test tasks.

• Can I get a similar job?
  
• What tasks are now free?
  
• What is the best way to contact you and where to ask questions?
  

I have one problem that I do not know how to begin to decide - there is knowledge, but I do not understand how to direct them to the mainstream of development. 

[Andrew Selkin]

Hi !

If you are intended to participate in GSoC you need to be a student. Are you a student? 

среда, 15 марта 2017 г., 20:39:09 UTC+3 пользователь mikhailo...@gmail.com написал:

[mikhailo...@gmail.com]

Of course!) Odessa Polytechnic University, 3rd year student
Need to send you a scan of the certificate from the university? Or a student record books?

[Roman Ivanov]

we do NOT need documents, You will need them during registration at GSoC web site.

try super easy issue - https://github.com/checkstyle/checkstyle/issues/4013

please make a comment in github "I am on it" to confirm assignment

​

[mikhailo...@gmail.com]

Excuse me, yes, I know that it is necessary at registration, but I thought that you also need it.

Thanks)

[mikhailo...@gmail.com]

Hmm, could you help me? I looked through the contents of the repository, but did not quite understand the task. Can you describe the problem in more detail?

[Ilja Dubinin]

Try to read parent issue: https://github.com/checkstyle/checkstyle/issues/3891

It should help you

On Fri, Mar 17, 2017 at 3:24 PM <mikhailo...@gmail.com> wrote:

Hmm, could you help me? I looked through the contents of the repository, but did not quite understand the task. Can you describe the problem in more detail?

--
You received this message because you are subscribed to the Google Groups "checkstyle-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to checkstyle-dev...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[mikhailo...@gmail.com]

I need to fix the re-opening of the same object in different tests?

[Ilja Dubinin]

kind of

We use code samples as input for our UTs and we want to prevent using of the same sample file (input) across tests for different checks.

It leads to unnecessary changes sometimes.

we have amount of examples in resolved PRs already, try to find something similar here: https://github.com/checkstyle/checkstyle/pulls?q=is%3Apr+is%3Aclosed

On Fri, Mar 17, 2017 at 3:28 PM <mikhailo...@gmail.com> wrote:

I need to fix the re-opening of the same object in different tests?

--

[mikhailo...@gmail.com]

Okey, thanks

How much time do I have to complete the task? Perhaps, before Sunday I can not do

пятница, 17 марта 2017 г., 17:37:33 UTC+2 пользователь Ilja Dubinin написал:

[Ilja Dubinin]

I don't think you will spend more then 3h on this issue, but if you don't have free time till Sunday - that's fine.

Do not forget about GSoC timeline. More issue you solve - more chances you have to be approved.

[mikhailo...@gmail.com]

I have error with import file

import com.puppycrawl.tools.checkstyle.grammars.javadoc.JavadocLexer;
import com.puppycrawl.tools.checkstyle.grammars.javadoc.JavadocParser;
could you help me?

[mikhailo...@gmail.com]

And

import com.puppycrawl.tools.checkstyle.grammars.GeneratedJavaTokenTypes;

воскресенье, 19 марта 2017 г., 11:31:26 UTC+2 пользователь mikhailo...@gmail.com написал:

[Ilja Dubinin]

Hi,

Try this: http://checkstyle.sourceforge.net/eclipse.html

[mikhailo...@gmail.com]

Hm, I used IDEA
There I have to do the same thing?

[mikhailo...@gmail.com]

IntelliJ Idea

воскресенье, 19 марта 2017 г., 13:47:29 UTC+2 пользователь mikhailo...@gmail.com написал:

[mikhailo...@gmail.com]

Oh, I figured it out


воскресенье, 19 марта 2017 г., 13:48:14 UTC+2 пользователь mikhailo...@gmail.com написал:

[mikhailo...@gmail.com]

Thanks
Plz, look my pull :)
https://github.com/checkstyle/checkstyle/pull/4056

[mikhailo...@gmail.com]

I realized what needs to be done
Today I will make more edits

[mikhailo...@gmail.com]

I deleted my pool now, because i'm broke him
If I want to add a new package in resources and unit tests from one group, then how to do it correctly? I added the package, and then transfer the files there, but it shows errors

[mikhailo...@gmail.com]

I clone your project, immediately ran the MainTest.java - all okey, next step - I ran  mvn cleam verify and it's issued 3 errors:

Results :

Tests in error:
  ConfigurationLoaderTest.testExternalEntity:324->loadConfiguration:67 » Checkstyle
  ConfigurationLoaderTest.testExternalEntityFromUri:355 » Checkstyle unable to p...
  ConfigurationLoaderTest.testExternalEntitySubdirectory:339->loadConfiguration:67 » Checkstyle

Tests run: 2000, Failures: 0, Errors: 3, Skipped: 0

How fix this?

[mikhailo...@gmail.com]

Sorry, if I ask too many questions, the more I start to understand, the more nuances appear
But since I want to get to you, i have to ask :))

And last questions:
Please, tell me, what's wrong with the path to the InputSimpleLineLength.java file? I prepared a package for it, changed the path to the file, changed the name, but it give the error:
https://github.com/MikhailovOlegM/checkstyle/blob/ae08ef900b1334423d776794c30479050d4e5c58/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/LineLengthCheckTest.java

[Ilja Dubinin]

Hi,

Give me the link to the input file in current state.

The message means that checkstyle expected line longer than 80 chars on the 18th line, but input does not violate the check.

I'm pretty sure you have changed something in file.

[mikhailo...@gmail.com]

https://github.com/MikhailovOlegM/checkstyle/blob/ae08ef900b1334423d776794c30479050d4e5c58/src/test/resources/com/puppycrawl/tools/checkstyle/checks/sizes/linelength/InputSimpleLineLength.java
I only rename this file from InputSimple in InputSimpleLineLength

понедельник, 20 марта 2017 г., 7:06:17 UTC+2 пользователь Ilja Dubinin написал:

[Ilja Dubinin]

1) I don't see actual rename. I see only creation of new file. Do any other checks use InputSimple?

2) I see the difference between InputSimple and InputSimpleLineLength. Check whitespace

--

[mikhailo...@gmail.com]

Oh, yes, thanks, I fixed this
But now i have last error and i don't know why I get them



понедельник, 20 марта 2017 г., 12:49:04 UTC+2 пользователь Ilja Dubinin написал:

[Roman Ivanov]

Please always share link to code and attach full log of error, not a picture.

To unsubscribe from this group and stop receiving emails from it, send an email to checkstyle-devel+unsubscribe@googlegroups.com.

[mikhailo...@gmail.com]

https://github.com/MikhailovOlegM/checkstyle/blob/master/src/test/java/com/puppycrawl/tools/checkstyle/ConfigurationLoaderTest.java - this test has crashed

[mikhailo...@gmail.com]

Perhaps this is due to the fact that I have the Russian word "Documents" in the file path?

понедельник, 20 марта 2017 г., 17:14:18 UTC+2 пользователь mikhailo...@gmail.com написал:

[mikhailo...@gmail.com]

I find bugs
My global path contains russian word - OLDPWD=/home/mikha/Документы/GSoC/checkstyle
I fix this and make commit
Can I get a new job after that i fix this error?

понедельник, 20 марта 2017 г., 17:15:44 UTC+2 пользователь mikhailo...@gmail.com написал:

[Ilja Dubinin]

We will assign new issue after you create pull request and we start code review. Until that task is not completed.

[mikhailo...@gmail.com]

Yes, of course
I work now

понедельник, 20 марта 2017 г., 18:23:02 UTC+2 пользователь Ilja Dubinin написал:

[mikhailo...@gmail.com]

Can I get the next issue?

[Roman Ivanov]

try https://github.com/checkstyle/checkstyle/issues/3504

do not forget to make comment in github

​

[mikhailo...@gmail.com]

Could you explain in more detail?

The code that is here https://github.com/checkstyle/checkstyle/issues/3504 I need to refactor him?
Is it not part of your project?

[Roman Ivanov]

all questions for issue, should be asked in github to keep context.​

You need to read code of Check and explain current behavior of Check.

if current behavior is intentional - we need to update documentation of Check.

if not intentional - fix the Check.