issue #1009

35 views
Skip to first unread message

Vladislav Lis

unread,
Apr 29, 2015, 12:42:01 PM4/29/15
to checksty...@googlegroups.com
code coverage 100% for package design

Roman Ivanov

unread,
Apr 29, 2015, 1:04:00 PM4/29/15
to Vladislav Lis, checksty...@googlegroups.com

Vladislav Lis

unread,
May 12, 2015, 2:19:39 PM5/12/15
to checksty...@googlegroups.com, vlad...@gmail.com
opened a pull request with coverage for methods getAccessibleTokens and getRequiredTokens
https://github.com/checkstyle/checkstyle/pull/1071

Roman Ivanov

unread,
May 12, 2015, 2:45:53 PM5/12/15
to Vladislav Lis, checksty...@googlegroups.com

Please fix build failures https://travis-ci.org/checkstyle/checkstyle/jobs/62267243#L1861 , make sure that "mvn verify" command pass successfuly

On May 12, 2015 8:19 AM, "Vladislav Lis" <vlad...@gmail.com> wrote:
opened a pull request with coverage for methods getAccessibleTokens and getRequiredTokens
https://github.com/checkstyle/checkstyle/pull/1071

--
You received this message because you are subscribed to the Google Groups "checkstyle-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to checkstyle-dev...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Vladislav Lis

unread,
May 13, 2015, 5:53:18 AM5/13/15
to checksty...@googlegroups.com, vlad...@gmail.com
Done

Vladislav Lis

unread,
May 13, 2015, 11:40:00 AM5/13/15
to checksty...@googlegroups.com

Vladislav Lis

unread,
May 16, 2015, 7:06:23 PM5/16/15
to checksty...@googlegroups.com
100% coverage for class DesignForExtensionCheck + fix for testGetRequiredTokens() in the package
commit bc22f42d4b37430577cf469b96dca96b3bf74e2b
pull request #1084
Message has been deleted

Vladislav Lis

unread,
May 18, 2015, 11:12:25 AM5/18/15
to checksty...@googlegroups.com
100% coverage for class HideUtilityClassConstructor
pull request #1095

Roman Ivanov

unread,
May 18, 2015, 2:56:07 PM5/18/15
to Vladislav Lis, checksty...@googlegroups.com
good, but please send me links to reports as http://vladlis.github.io/com.puppycrawl.tools.checkstyle.checks.design.HideUtilityClassConstructorCheck.html
As you remove line for that Check from pom.xml configuration , I do not need report as I sure that cobertura will demand 100%, so please send me reports only for problematic cases.

--

Vladislav Lis

unread,
May 18, 2015, 3:39:44 PM5/18/15
to checksty...@googlegroups.com, vlad...@gmail.com
100% coverage for class ThrowsCountCheck
pull request #1097

Roman Ivanov

unread,
May 18, 2015, 4:02:13 PM5/18/15
to Vladislav Lis, checksty...@googlegroups.com
no need to put there a comment about events in github, I receive all eents from github - I will not miss them.
Here we do only discussion for problematic cases.
​
Reply all
Reply to author
Forward
0 new messages