Should SuppressionFilter use OS-independent paths

6 views
Skip to first unread message

Pavel Baranchikov

unread,
Oct 5, 2015, 11:00:17 AM10/5/15
to checkstyle-devel
Hello.

We have some code, that we do not want to check by Checkstyle, that's why we use
SuppressionFilter.

I found a nasty behaviour, that files attribute specifies paths in OS-specific manner.

Take a look at http://stackoverflow.com/questions/13874582/what-is-the-correct-syntax-to-suppress-specific-checkstyle-rules-on-certain-file
I think, it's awful to use constructions, like this:

files="my[\\/]super[\\/]package[\\/]name"

I suggest to go by Ant's path. Expect all the files to have unix-like path separators (/) and apply them correctly on all paths, including Windows.

Any objections here?

Thanks in advance,
Pavel.

Michal Kordas

unread,
Oct 5, 2015, 11:37:24 AM10/5/15
to Pavel Baranchikov, checkstyle-devel

Hi,

No objections from me. Ant paths are pretty much standard in tools similar to Checkstyle. Could you please create issue on GitHub?

The only concern is backward compatibility. Would it require 7.0 release?

Thanks,
Michal

--
You received this message because you are subscribed to the Google Groups "checkstyle-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to checkstyle-dev...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Pavel Baranchikov

unread,
Oct 5, 2015, 11:48:16 AM10/5/15
to checkstyle-devel, p.a.bar...@gmail.com
Reply all
Reply to author
Forward
0 new messages