Certificate-Transperancy-Java library contribution

[aaga...@qualys.com]

I have added one important API get-proof-by-hash in certificate-transperancy-java library.

But I am unable to merge it because it needs CLA for one or more commit authors.

Link to GitHub pull request : https://github.com/google/certificate-transparency-java/pull/18

[Martin Smith]

Hi,

You'll need to sort out the CLA before we can proceed. Possibly the commit email address doesn't match the one that has signed the CLA?

Thanks,

Martin

--
You received this message because you are subscribed to the Google Groups "certificate-transparency" group.
To unsubscribe from this group and stop receiving emails from it, send an email to certificate-transp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/certificate-transparency/87602c96-a8a3-4baa-b620-4108ad49014a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Ankish Agarwal]

Hi Martin,

 

I have signed a CLA, following is the message from google bot.

 

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

To view this discussion on the web visit https://groups.google.com/d/msgid/certificate-transparency/CAK76_KWOHLYp2URMYWDuTmyPFRBZ_Vyq8wS3wMwszd3iMFk5-g%40mail.gmail.com.

[Martin Smith]

Hi,

The CLA system is automatic so it needs to see a match between the email address you've signed the CLA for and the one in the Git commit. E.g. if you signed with your @qualsys address it won't match the @gmail.com in the commit.

Thanks,

Martin 

To view this discussion on the web visit https://groups.google.com/d/msgid/certificate-transparency/4e9880223e8079eb0f2683009d54f6f5%40mail.gmail.com.

[Ankish Agarwal]

Hi Martin,

 

I have committed the latest code changes using aaga...@qualys.com email ID. I have used the same email ID to sign CLA.

 

commit 5b921db69e8d64ee0cd2fe8d8079153f28c6c131 (HEAD -> master, origin/master, origin/HEAD)

Author: aagarwal <aaga...@qualys.com>

Date:   Mon May 14 15:20:03 2018 +0530

 

It is still showing me the same error.

 

Regards,

Ankish

To view this discussion on the web visit https://groups.google.com/d/msgid/certificate-transparency/CAK76_KU-vTjSQFH1CpjB8yzEVwbkNmD1fR%2B4-jXV%2Bf1ckRzBwg%40mail.gmail.com.

[Martin Smith]

Hi,

It's not the email address in the Contributors file that's the problem. It's the one attached to the Git commit itself.

Thanks,

Martin

To view this discussion on the web visit https://groups.google.com/d/msgid/certificate-transparency/7c9ba34ce71e19e2747ed1bef282040d%40mail.gmail.com.

[Ankish Agarwal]

Hi Martin,

 

I had made sure the email attached to git commit and the email used to signed CLA are same. Following is the latest Git log output.

Should I make a new pull request ?

 

$ git log

commit 334a934b1a6bff58a288736d943919141afdbe11 (HEAD -> master, origin/master, origin/HEAD)

Merge: 559c0b5 639eb1b

Author: aagarwal <aaga...@qualys.com>

Date:   Mon May 14 16:05:48 2018 +0530

To view this discussion on the web visit https://groups.google.com/d/msgid/certificate-transparency/CAK76_KXpj20qJhAd1iekW7nbceGx1D3V41SeP2vNrUkWt-VC%2Bg%40mail.gmail.com.

[Martin Smith]

Hi,

It's probably looking at all the commits. If you rebase it and squash them down it might work. Or I think signing the CLA with the gmail address and adding a comment might also fix it.

Martin

To view this discussion on the web visit https://groups.google.com/d/msgid/certificate-transparency/0c45b6a936d61b49c82ff83b7b1ab5db%40mail.gmail.com.

[Ankish Agarwal]

Hi Martin,

 

Unfortunately it didn’t worked.

I have created a new pull request at https://github.com/google/certificate-transparency-java/pull/19

 

I have included all the changes post code review here. Please have a look.

 

Thanks,

To view this discussion on the web visit https://groups.google.com/d/msgid/certificate-transparency/CAK76_KVX8b9s_yz6rqR5TbpDDNFBFmKRWcztOu-e%2BhOFEugYYA%40mail.gmail.com.