Castle.Core mono bug affects GenericUtil.cs:AdjustGenericConstraints() fixed in a simple way.

49 views
Skip to first unread message

Ralph Alexander Bariz

unread,
Jun 13, 2015, 8:12:41 PM6/13/15
to castle-pro...@googlegroups.com
The other crash happening when bypassed this, is fixed with mono 4.3.0


contributing a patch would not make sense, since adding the fix is a one line thing. simplyreplace constraints[i] = Adjust... with something like retConstraints[i] = Adjust... where retConstraints is a new Type[constraints.Length]

Kind Regards

PS: a message when this is implemented would be nice so I can stop carrying a castle.core fork around

Jonathon Rossi

unread,
Jun 22, 2015, 9:25:42 AM6/22/15
to Castle Project Users, alph....@gmail.com
Hi Ralph,

See https://github.com/castleproject/Core/issues/81 for the issue that was already logged and the progress we are making.

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Jonathon Rossi

unread,
Jun 22, 2015, 9:27:05 AM6/22/15
to Castle Project Users, ralph...@gmail.com
Just for future sake do you know if that issue was ever logged in the mono issue tracker because I couldn't find anything relevant.
--
Jono

Ralph Alexander Bariz

unread,
Jun 23, 2015, 4:43:54 AM6/23/15
to castle-pro...@googlegroups.com, ralph...@gmail.com
the generics thing, yes. the type thing fixed with this, no... at least not from me.

Ralph


Am Montag, 22. Juni 2015 15:27:05 UTC+2 schrieb Jonathon Rossi:
Just for future sake do you know if that issue was ever logged in the mono issue tracker because I couldn't find anything relevant.
On Mon, Jun 22, 2015 at 11:25 PM, Jonathon Rossi <jo...@jonorossi.com> wrote:
Hi Ralph,

See https://github.com/castleproject/Core/issues/81 for the issue that was already logged and the progress we are making.
On Sun, Jun 14, 2015 at 5:18 AM, Ralph Alexander Bariz <ralph...@gmail.com> wrote:
The other crash happening when bypassed this, is fixed with mono 4.3.0


contributing a patch would not make sense, since adding the fix is a one line thing. simplyreplace constraints[i] = Adjust... with something like retConstraints[i] = Adjust... where retConstraints is a new Type[constraints.Length]

Kind Regards

PS: a message when this is implemented would be nice so I can stop carrying a castle.core fork around

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

Jonathon Rossi

unread,
Jun 23, 2015, 7:17:45 AM6/23/15
to Castle Project Users, Ralph Alexander Bariz
Can you post a link to the logged issue for what you are referring to by "the type thing fixed with this, no".

On Tue, Jun 23, 2015 at 6:43 PM, Ralph Alexander Bariz <ralph...@gmail.com> wrote:
the generics thing, yes. the type thing fixed with this, no... at least not from me.

Ralph

Am Montag, 22. Juni 2015 15:27:05 UTC+2 schrieb Jonathon Rossi:
Just for future sake do you know if that issue was ever logged in the mono issue tracker because I couldn't find anything relevant.
On Mon, Jun 22, 2015 at 11:25 PM, Jonathon Rossi <jo...@jonorossi.com> wrote:
Hi Ralph,

See https://github.com/castleproject/Core/issues/81 for the issue that was already logged and the progress we are making.
On Sun, Jun 14, 2015 at 5:18 AM, Ralph Alexander Bariz <ralph...@gmail.com> wrote:
The other crash happening when bypassed this, is fixed with mono 4.3.0


contributing a patch would not make sense, since adding the fix is a one line thing. simplyreplace constraints[i] = Adjust... with something like retConstraints[i] = Adjust... where retConstraints is a new Type[constraints.Length]

Kind Regards

PS: a message when this is implemented would be nice so I can stop carrying a castle.core fork around

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Ralph Alexander Bariz

unread,
Jun 23, 2015, 8:17:04 AM6/23/15
to castle-pro...@googlegroups.com, ralph...@gmail.com
To do so, I would need to find it. Since it's a time ago, the bugtracking system lack of a reporterassignment list and I do not know exactly what I wrote... I simply do not find it :( Sorry.


Am Dienstag, 23. Juni 2015 13:17:45 UTC+2 schrieb Jonathon Rossi:
Can you post a link to the logged issue for what you are referring to by "the type thing fixed with this, no".
On Tue, Jun 23, 2015 at 6:43 PM, Ralph Alexander Bariz <ralph...@gmail.com> wrote:
the generics thing, yes. the type thing fixed with this, no... at least not from me.

Ralph

Am Montag, 22. Juni 2015 15:27:05 UTC+2 schrieb Jonathon Rossi:
Just for future sake do you know if that issue was ever logged in the mono issue tracker because I couldn't find anything relevant.
On Mon, Jun 22, 2015 at 11:25 PM, Jonathon Rossi <jo...@jonorossi.com> wrote:
Hi Ralph,

See https://github.com/castleproject/Core/issues/81 for the issue that was already logged and the progress we are making.
On Sun, Jun 14, 2015 at 5:18 AM, Ralph Alexander Bariz <ralph...@gmail.com> wrote:
The other crash happening when bypassed this, is fixed with mono 4.3.0


contributing a patch would not make sense, since adding the fix is a one line thing. simplyreplace constraints[i] = Adjust... with something like retConstraints[i] = Adjust... where retConstraints is a new Type[constraints.Length]

Kind Regards

PS: a message when this is implemented would be nice so I can stop carrying a castle.core fork around

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Jonathon Rossi

unread,
Jun 23, 2015, 8:24:55 AM6/23/15
to Castle Project Users, Ralph Alexander Bariz
I can't find any issues logged by you on our issue tracker, did you log it on the mono or ours?

On Tue, Jun 23, 2015 at 10:17 PM, Ralph Alexander Bariz <ralph...@gmail.com> wrote:
To do so, I would need to find it. Since it's a time ago, the bugtracking system lack of a reporterassignment list and I do not know exactly what I wrote... I simply do not find it :( Sorry.

Am Dienstag, 23. Juni 2015 13:17:45 UTC+2 schrieb Jonathon Rossi:
Can you post a link to the logged issue for what you are referring to by "the type thing fixed with this, no".
On Tue, Jun 23, 2015 at 6:43 PM, Ralph Alexander Bariz <ralph...@gmail.com> wrote:
the generics thing, yes. the type thing fixed with this, no... at least not from me.

Ralph

Am Montag, 22. Juni 2015 15:27:05 UTC+2 schrieb Jonathon Rossi:
Just for future sake do you know if that issue was ever logged in the mono issue tracker because I couldn't find anything relevant.
On Mon, Jun 22, 2015 at 11:25 PM, Jonathon Rossi <jo...@jonorossi.com> wrote:
Hi Ralph,

See https://github.com/castleproject/Core/issues/81 for the issue that was already logged and the progress we are making.
On Sun, Jun 14, 2015 at 5:18 AM, Ralph Alexander Bariz <ralph...@gmail.com> wrote:
The other crash happening when bypassed this, is fixed with mono 4.3.0


contributing a patch would not make sense, since adding the fix is a one line thing. simplyreplace constraints[i] = Adjust... with something like retConstraints[i] = Adjust... where retConstraints is a new Type[constraints.Length]

Kind Regards

PS: a message when this is implemented would be nice so I can stop carrying a castle.core fork around

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Ralph Alexander Bariz

unread,
Jun 23, 2015, 8:32:21 AM6/23/15
to castle-pro...@googlegroups.com, ralph...@gmail.com
@https://bugzilla.xamarin.com/

Wasn't a "Castle.Core not working with Mono 4", but the problem I faced when debugging the whole (My app contains another proxying mechanism I didn't exchage with castle.core unitl now facing similar problems).


Am Dienstag, 23. Juni 2015 14:24:55 UTC+2 schrieb Jonathon Rossi:
I can't find any issues logged by you on our issue tracker, did you log it on the mono or ours?

On Tue, Jun 23, 2015 at 10:17 PM, Ralph Alexander Bariz <ralph...@gmail.com> wrote:
To do so, I would need to find it. Since it's a time ago, the bugtracking system lack of a reporterassignment list and I do not know exactly what I wrote... I simply do not find it :( Sorry.

Am Dienstag, 23. Juni 2015 13:17:45 UTC+2 schrieb Jonathon Rossi:
Can you post a link to the logged issue for what you are referring to by "the type thing fixed with this, no".
On Tue, Jun 23, 2015 at 6:43 PM, Ralph Alexander Bariz <ralph...@gmail.com> wrote:
the generics thing, yes. the type thing fixed with this, no... at least not from me.

Ralph

Am Montag, 22. Juni 2015 15:27:05 UTC+2 schrieb Jonathon Rossi:
Just for future sake do you know if that issue was ever logged in the mono issue tracker because I couldn't find anything relevant.
On Mon, Jun 22, 2015 at 11:25 PM, Jonathon Rossi <jo...@jonorossi.com> wrote:
Hi Ralph,

See https://github.com/castleproject/Core/issues/81 for the issue that was already logged and the progress we are making.
On Sun, Jun 14, 2015 at 5:18 AM, Ralph Alexander Bariz <ralph...@gmail.com> wrote:
The other crash happening when bypassed this, is fixed with mono 4.3.0


contributing a patch would not make sense, since adding the fix is a one line thing. simplyreplace constraints[i] = Adjust... with something like retConstraints[i] = Adjust... where retConstraints is a new Type[constraints.Length]

Kind Regards

PS: a message when this is implemented would be nice so I can stop carrying a castle.core fork around

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Jonathon Rossi

unread,
Jun 23, 2015, 9:05:12 AM6/23/15
to Castle Project Users, Ralph Alexander Bariz
Looks like you are only listed as a person on two issues, is this the issue?

To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Ralph Alexander Bariz

unread,
Jun 23, 2015, 9:48:12 AM6/23/15
to castle-pro...@googlegroups.com, ralph...@gmail.com
yes it is, where did you find my bug report overview?
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Jonathon Rossi

unread,
Jun 24, 2015, 12:20:20 AM6/24/15
to Castle Project Users, Ralph Alexander Bariz
I just went to the Advanced Search and put your email address into the second option for "Search By People".

In that bug report are you saying that the "Assertion at sgen-alloc.c:460, condition `*p == NULL' not met" assertion occurs in 4.0.1 (which we are already aware of and is fixed in https://bugzilla.xamarin.com/show_bug.cgi?id=28182), but with the CI builds post-4.0.1 that another assertion occurs "Assertion at method-to-ir.c:13533, condition `ins->opcode >= MONO_CEE_LAST' not met"? If so, then that one is new to me and we'll need to add that to the list in https://github.com/castleproject/Core/issues/94.

To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Ralph Alexander Bariz

unread,
Jun 24, 2015, 4:27:56 AM6/24/15
to castle-pro...@googlegroups.com, ralph...@gmail.com
Good Morning

No, as you can see in the stacktrace, this assertion affects OpenTKs Cloo. It has nothing to do with Castle.Core and also shows up only in mono-snapshot (4.3.0).

BR
Ralph
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Jonathon Rossi

unread,
Jun 24, 2015, 8:13:12 AM6/24/15
to Castle Project Users, Ralph Alexander Bariz
Ah, thanks. I didn't quite notice you trimmed all of the stack traces.

So back to the question I was trying to answer, you mentioned another mono crash which I was trying to make sure we've got listed so, does that issue remind you what the issue was:


> The other crash happening when bypassed this, is fixed with mono 4.3.0

> the generics thing, yes. the type thing fixed with this, no... at least not from me.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Ralph Alexander Bariz

unread,
Jun 25, 2015, 3:17:59 AM6/25/15
to castle-pro...@googlegroups.com, ralph...@gmail.com
Good Morning,

From my side there is no further bug. Just this two, the one I sugessted a workaround here and the assertion problem you already mentioned and is fixed in 4.3.0.

BR
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-users+unsub...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Jonathon Rossi

unread,
Jun 25, 2015, 9:07:16 AM6/25/15
to Castle Project Users, Ralph Alexander Bariz
Great, thanks.

To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.
To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-u...@googlegroups.com.

To post to this group, send email to castle-pro...@googlegroups.com.
Visit this group at http://groups.google.com/group/castle-project-users.
For more options, visit https://groups.google.com/d/optout.



--
Jono

Ralph Alexander Bariz

unread,
Jul 4, 2015, 1:40:44 PM7/4/15
to Jonathon Rossi, Castle Project Users
Hi Jonathon,

I cloned the repo locally and finally I'm able to run the tests with mono 4.0.2 in ubuntu 15.04. At least with nunit-console from bash. Monodevelop is not recognizing the tests for some reasons.

I'll commit in my local repo, in the attachments you get the diff file.
* I introduced a new configuration mono43(now after they released mono 4.0.2 where everything is working I expected from 4.3, it's not really right... well I'll change later),
* I commented out the test exclusions and I updated the nunit framework.
* Also I had to remove a few <choice> tags from the project files, monodevelop had a problem with them. need to test that with vs, but I fear, for the tests and the logging not for the lib itself, the 2.0 and 3.5 support is gone. lets see, I'll try to investigate further solve that. For the moment fixing the real problems has a higher prio.
* Also for mono I had to remove the "treat warnings as errors" thing. But as I remember, also vs.net is throwing warnings when finding unused variables, right? Yeah, maybe you can take a look. When I've done what I can, I'll send a final patch.

Best Regards
Ralph
-----------------------------------------------------------------------------------------------------
ralph@ralph-laptop:~/Projects/Castle.Core$ git pull
Already up-to-date.
ralph@ralph-laptop:~/Projects/Castle.Core$ git commit --dry-run -am "modified things for building with mono 4.0.2 on ubuntu"
Auf Branch master
Ihr Branch ist auf dem selben Stand wie 'origin/master'.
zum Commit vorgemerkte Änderungen:
  (benutzen Sie "git reset HEAD <Datei>..." zum Entfernen aus der Staging-Area)

    geändert:       Castle.Core.sln
    geändert:       lib/nunit.framework.dll
    geändert:       src/Castle.Core.Tests-SL/Castle.Core.Tests-SL.csproj
    geändert:       src/Castle.Core.Tests/Castle.Core.Tests.csproj
    geändert:       src/Castle.Core.Tests/GenericClassProxyTestCase.cs
    geändert:       src/Castle.Core.Tests/GenericMethodsProxyTestCase.cs
    geändert:       src/Castle.Core.Tests/TraceLoggerTests.cs
    geändert:       src/Castle.Core/Castle.Core.csproj
    geändert:       src/Castle.Services.Logging.NLogIntegration/Castle.Services.Logging.NLogIntegration.csproj
    geändert:       src/Castle.Services.Logging.SerilogIntegration/Castle.Services.Logging.SerilogIntegration.csproj
    geändert:       src/Castle.Services.Logging.log4netIntegration/Castle.Services.Logging.log4netIntegration.csproj

Unbeobachtete Dateien:
  (benutzen Sie "git add <Datei>...", um die Änderungen zum Commit vorzumerken)

    Castle.Core.userprefs
    TestResult.xml
    lib/nunit.framework.xml
    tests.sh

2c7bb34.patch

Ralph Alexander Bariz

unread,
Jul 4, 2015, 3:17:20 PM7/4/15
to Jonathon Rossi, Castle Project Users
Hi,

I decided to send the patches one by one, may be a bit more manageable.
Here I completely removed the hard reference to nunit, and replaced it by the nuget package(without monodevelop is not recognizing the project as nunit testproject and the integration is not working)

problem was, you assumend with dotnet45 passing the defaultvalues of a parameter works. well mono 4 "is" dotnet45 and doesn't support that.

BR
Ralph
eab3755.patch

Ralph Alexander Bariz

unread,
Jul 4, 2015, 4:07:08 PM7/4/15
to Jonathon Rossi, Castle Project Users
And, I checked all ignored and failed tests of dynamicproxy. The defaultvalue for parameter tests I had to take out for mono. dotnet45 sadly is not mono dotnet45. the hope: they seem to merge in near future :D
I gone through all dynamicproxy tests. They should be up to date now.
Sorry for the huge patch file, the different lineendings thing seems to stay a problem even after I enabled windows line endings by default :(

Ralph
abca6ce_f5b3b0b.patch

Jonathon Rossi

unread,
Jul 6, 2015, 3:20:48 AM7/6/15
to Castle Project Users
Don't worry you didn't create multiple threads in the mailing list, that just showed multiple posts.

I think thread (i.e. mono bug affecting GenericUtil.cs:AdjustGenericConstraints) is finished, you should create a new thread if you like to discuss something else. Also this is the Castle Users mailing list for helping with users problems, not for the development of Castle, see the Castle Devel mailing list (http://www.castleproject.org/get-involved/mailing-lists/). FYI, both lists are very low volume so it isn't a problem to just subscribe to them like a normal mailing list rather than a daily digest.

To be honest it is also much easier to discuss code changes in a GitHub pull request rather than patches on the mailing list like we used to do 5 years ago.
--
Jono

Ralph Alexander Bariz

unread,
Jul 6, 2015, 3:25:07 AM7/6/15
to Castle Project Users

My intention was to mail you the patches. Git pull request sounds good but I've got no idea about. Need to read a bit. I'm pretty new to github ^^

BR
Ralph


You received this message because you are subscribed to a topic in the Google Groups "Castle Project Users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/castle-project-users/Ef4VatENDaM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to castle-project-u...@googlegroups.com.

Jonathon Rossi

unread,
Jul 6, 2015, 3:30:25 AM7/6/15
to Castle Project Users
Oh, those emails with patches definitely went to the list too.

Don't worry, GitHub pull requests are pretty easy to use, take a read of this:

Basically you fork the castleproject/Core repository under your name, then commit changes on a branch, push to your fork, click the new pull request button on the web UI, and presto we can review, comment and merge your code from GitHub.com.

Ralph Alexander Bariz

unread,
Jul 6, 2015, 3:35:41 AM7/6/15
to Castle Project Users
ah nice. will do so.

Think you'll get notified when I create that pull request.

Ralph

Jonathon Rossi

unread,
Jul 6, 2015, 3:39:48 AM7/6/15
to Castle Project Users
Yep, all watchers (https://github.com/castleproject/Core/watchers) of the repository will be notified when you send the PR.

Oh, and after you send the pull request if you update your branch with new commits the pull request automatically updates, no need to close and make a new one.
Reply all
Reply to author
Forward
0 new messages