Regression for PR #29

9 views
Skip to first unread message

Christian Romming

unread,
Sep 12, 2016, 12:44:35 AM9/12/16
to cascading-user
Hi,

There are two current issues with PR #29:
  1. The part of PR #29 that deals with unwritable traps was lost somewhere along the way: This commit has TrapHandler.getTrapCollector() throw a TrapException when openForWrite() throws one, but in its new home in FlowProcess it's back to throwing a DuctException. This causes the original problem to resurface, i.e. the flow succeeds and the exception is propagated to the wrong trap.
  2. This problem isn't exhibited by a test in PR #29. Here's an adaptation of the test that does, but it only works on the cascading-local platform because I don't know how to set up an invalid path on other platforms.
Let me know if there's something I can do to help get this fixed.

Thanks!

Chris K Wensel

unread,
Sep 22, 2016, 5:07:39 PM9/22/16
to cascadi...@googlegroups.com
if you can provide alternative test, that would be great.

the testTrapFailure is still in play and passes, so an improved version that exercises your issue would be great.

--
You received this message because you are subscribed to the Google Groups "cascading-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cascading-use...@googlegroups.com.
To post to this group, send email to cascadi...@googlegroups.com.
Visit this group at https://groups.google.com/group/cascading-user.
To view this discussion on the web visit https://groups.google.com/d/msgid/cascading-user/2444223e-5964-4ac8-afcf-32c4e3325f0d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Reply all
Reply to author
Forward
0 new messages