Re: [davidswelt/aquamacs-emacs] Fixed missing keyboard shortcuts in html-helper-mode (#117)

[David Reitter]

Hayo,

About this change of yours:

-'(require 'cl)
+(require 'cl)

This effectively un-comments the line.
Is it necessary to fix a bug?

We do not want to load `cl’ unconditionally because of the potential for incompatibilities. (This is a GNU Emacs dev mantra..)
Preferably, we would want to require cl-macs if necessary.

- David




> On Nov 28, 2016, at 3:41 AM, Hayo Baan <notifi...@github.com> wrote:
>
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/davidswelt/aquamacs-emacs/pull/117
>
> Commit Summary
>
> • Fixed missing keyboard shortcuts in html-helper-mode
> File Changes
>
> • M aquamacs/src/site-lisp/edit-modes/html-helper-mode.el (5)
> Patch Links:
>
> • https://github.com/davidswelt/aquamacs-emacs/pull/117.patch
> • https://github.com/davidswelt/aquamacs-emacs/pull/117.diff
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>