ANTLR exit codes

[Mike Lischke]

Hi,

I couldn't find any information about the exit status of the ANTLR tool (only a question in the old antlr-interest list). So, what does ANTLR set on successful generation or in an error case?

It seems as if it always returns 0 currently, which means other build tools which depend on this step never know if they should continue or not. But I might be wrong.

Mike
--
www.soft-gems.net

[Gerald Rosenberg]

The relevant code in Tool.java (line 207) is

    if (antlr.errMgr.getNumErrors() > 0) {
         antlr.exit(1);
    }
    antlr.exit(0);
 }

[Mike Lischke]

The relevant code in Tool.java (line 207) is

    if (antlr.errMgr.getNumErrors() > 0) {
         antlr.exit(1);
    }
    antlr.exit(0);
 }

Thanks Gerald, but somehow this isn't really at the core of the problem. In XCode I get a warning that a tool issued error messages but did not set the exit code to != 0 when I run ANTLR4 in a script. That seems to indicate that the exit code was still 0, even when there are errors.

I even tried this code in my script:

if [ $? -eq 0 ]; then

  echo "Success"

else

  echo "Fail"

fi

but it always shows "Success". There must be something between Java and OSX that doesn't work as expected. But then it's not really an ANTLR problem.

Mike
-- 
www.soft-gems.net

[Loring Craymer]

Mike--

I doubt that it is an OSX issue; I believe that it is a sign that not all exceptions invoke the error manager. Try running antlr over a file that has errors in a debugger and catch exceptions as they are thrown. That should help you localize the problem, although the error manager is also used to issue warnings which will not be counted as errors but will use System.err.

--Loring

[Gerald Rosenberg]

The tool has an option ("-Werror") to treat warnings as errors.

[Mike Lischke]

The tool has an option ("-Werror") to treat warnings as errors.

The messages I got were errors already, so this wouldn't help. I'll play a bit with that in Eclipse to see if ANTLR really returns the correct exit code and/or this code doesn't end up in scripts.

On Wednesday, September 21, 2016 at 12:38:34 AM UTC-7, Mike Lischke wrote:

The relevant code in Tool.java (line 207) is

    if (antlr.errMgr.getNumErrors() > 0) {
         antlr.exit(1);
    }
    antlr.exit(0);
 }

Thanks Gerald, but somehow this isn't really at the core of the problem. In XCode I get a warning that a tool issued error messages but did not set the exit code to != 0 when I run ANTLR4 in a script. That seems to indicate that the exit code was still 0, even when there are errors.

Mike
-- 
www.soft-gems.net

[Jim Idle]

Is the script that is running the antlr tool capturing the antlr exit code and passing it on externally? I have not used XCode in a long time, but if the tool is being called via some kind of script harness and does not pass on the exit code, then this can happen. ANTLR exits with exit(1), the script captures that, but the script then just exits with 0. Just a thought.

Jim

--
You received this message because you are subscribed to the Google Groups "antlr-discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to antlr-discussion+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Mike Lischke]

Is the script that is running the antlr tool capturing the antlr exit code and passing it on externally? I have not used XCode in a long time, but if the tool is being called via some kind of script harness and does not pass on the exit code, then this can happen. ANTLR exits with exit(1), the script captures that, but the script then just exits with 0. Just a thought.

I just double checked and see now that the script handles the error code as it should. Either that code is not returned to XCode or XCode itself has a problem. In either case it's not an ANTLR problem.

Mike
-- 
www.soft-gems.net