review : l3mhdp.c memleak fix

27 views
Skip to first unread message

pavi1729

unread,
Dec 31, 2015, 2:44:19 AM12/31/15
to Android Linux Kernel Development
Hi,
  Want to know if this is a proper fix. Will send a proper patch if need be.

FILE :https://android.googlesource.com/kernel/tegra/+/android-tegra-3.10/net/mhi/l3mhdp.c



diff --git a/net/mhi/l3mhdp.c b/net/mhi/l3mhdp.c
index b9e641e..2e90ef3 100644
--- a/net/mhi/l3mhdp.c
+++ b/net/mhi/l3mhdp.c
@@ -551,8 +551,10 @@ mhdp_netdev_rx(struct sk_buff *skb, struct net_device *dev)
                                        ((mhdp_header_len - skb_headlen(skb)) +
                                        offset)));
                        if ((ip_ver>>4) != VER_IPv4 &&
-                               (ip_ver>>4) != VER_IPv6)
+                               (ip_ver>>4) != VER_IPv6) {
+                               dev_kfree_skb(newskb);
                                goto error;
+                       }
 
                } else {
                        DPRINTK("Error in the data received");

Reply all
Reply to author
Forward
0 new messages