1 patch for 2 projects?

43 views
Skip to first unread message

Ralph Bergmann | the4thFloor.eu

unread,
Sep 22, 2014, 2:04:43 PM9/22/14
to android...@googlegroups.com
Hello,


I want to write a patch for the FragmentManager.

The problem: The FragmentManager is in platform/frameworks/base and in
platform/frameworks/support (for the support library).

My question: Can I commit 1 patch for both projects? Or do I have to
write 2 patches? But when I write 2 patches both depends on each other.
How to do that?


Thanks a lot, Ralph

signature.asc

Adam Powell

unread,
Sep 22, 2014, 2:14:28 PM9/22/14
to android...@googlegroups.com
You will need to write two patches.

There should be no dependencies from one to the other as they are disjoint implementations. Either one should function independently.

Brian Carlstrom

unread,
Sep 23, 2014, 1:05:36 AM9/23/14
to android...@googlegroups.com
You can make the gerrit Change-Id the same to correlate them, but it isn't required.

-bri

--

---
You received this message because you are subscribed to the Google Groups "Android Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to android-contr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Ralph Bergmann | the4thFloor.eu

unread,
Sep 23, 2014, 12:51:43 PM9/23/14
to android...@googlegroups.com
Am 22.09.14 um 20:14 schrieb 'Adam Powell' via Android Contributors:
> There should be no dependencies from one to the other as they are
> disjoint implementations. Either one should function independently.

But how to make sure that both are merged or rejected? I think the
functionality of both FragmentManagers has to be in sync.



Ralph

signature.asc

Glenn Kasten

unread,
Sep 23, 2014, 12:52:40 PM9/23/14
to android...@googlegroups.com
Just mention it in Gerrit - add your own comment.

Brian Carlstrom

unread,
Sep 24, 2014, 4:07:50 AM9/24/14
to android...@googlegroups.com
right, its just by convention. you aren't missing any magic. this is a
gerrit/repo limitation right now.

-bri
Reply all
Reply to author
Forward
0 new messages